Unset environment variables that are used by Autotools packages.#8623
Merged
becker33 merged 1 commit intospack:developfrom Jun 24, 2020
Merged
Unset environment variables that are used by Autotools packages.#8623becker33 merged 1 commit intospack:developfrom
becker33 merged 1 commit intospack:developfrom
Conversation
Member
I think that would be a bad idea. We would have to change the |
skosukhin
force-pushed
the
clean_env
branch
2 times, most recently
from
eba8d43 to
6c1fa36
Compare
Member
Author
|
This obviously affects CMake packages too. |
Member
Author
|
@adamjstewart @alalazo can we give this another try?
|
adamjstewart
approved these changes
Mar 19, 2020
Member
|
I put that in for consideration in the next non bug-fix release. |
Member
|
Closing and reopening to restart the tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It happens that the listed variables (see the changes) are set in the environment and affect the installation process of Autotools packages. With this PR, Spack unsets them when it's run with
--cleanflag (by default).Probably, putting this logic to the
setup_environmentofAutotoolsPackageis better but I don't know the best way to get the value ofargs.dirtyfrom there.