bugfix: fix macos incompatibility in lock test#8573
Merged
Conversation
healther
reviewed
Jun 26, 2018
| env: [ TEST_SUITE=build, COVERAGE=true, 'SPEC=mpich' ] | ||
|
|
||
| stages: | ||
| - 'flake8 + documentation' |
Contributor
There was a problem hiding this comment.
why are these commented out?
Member
Author
There was a problem hiding this comment.
Testing just the mac os part, which only runs as a cron job. All of that will be reverted once the Mac OS builder passes.
tgamblin
force-pushed
the
bugfix/travis-macos-build
branch
from
0c22943 to
0f04211
Compare
healther
approved these changes
Jun 26, 2018
alalazo
approved these changes
Jun 26, 2018
- Spack was assuming that a group with gid == current uid would always exist. - This was breaking the travis build for macos. - also fix issue with the DB tarball test finding coverage filesx
tgamblin
force-pushed
the
bugfix/travis-macos-build
branch
2 times, most recently
from
62855cc to
ce82d17
Compare
Member
Author
|
Ok, this made the mac build succeed. Here is the log of the successful build (with only the macos stage enabled): I've reverted the commit that enabled the mac build on all PRs, so this is now safe to merge. Feel free to do so. |
Member
|
I restarted Travis as it failed during build tests 😓 Hopefully it will go green so that I can merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8225.
Spack was assuming that a group with gid == current uid would always exist.
This was breaking the travis build for macos.
also fixed a bug in the
create_db_tarballtest where.coverage.*files weren't properly considered.