xsdk: update xsdk@develop to use plasma@develop#8555
Conversation
| depends_on('[email protected]~int64+hypre', when='@develop') | ||
|
|
||
| depends_on('plasma@17.1', when='@develop %gcc@4.9:') | ||
| depends_on('plasma@develop', when='@develop %gcc@6.0:') |
There was a problem hiding this comment.
if you know that this will hold for next release, you can write [email protected]: and Spack will currently choose develop but as soon as 17.2 is released, it will choose the stable version.
There was a problem hiding this comment.
Hm perhaps @luszczek knows what the next release number will be. If it is 17.2 - I can add it in.
There was a problem hiding this comment.
Ah - I was using 17.2 in other parts anyway - so changed to 17.2 here aswell. We can update this later if needed
| @@ -44,7 +44,8 @@ class Plasma(MakefilePackage): | |||
| conflicts("veclibfort") | |||
|
|
|||
| # only GCC 4.9+ and higher have sufficient support for OpenMP 4+ tasks+deps | |||
There was a problem hiding this comment.
maybe slightly reword this comment as it does not apply to both conflicts
|
I've added 'don't-merge-yet' tag - as some of my tests are failing. So will try to resolve that first |
| depends_on('[email protected]~int64+hypre', when='@develop') | ||
|
|
||
| depends_on('plasma@17.1', when='@develop %gcc@4.9:') | ||
| depends_on('plasma@develop', when='@17.2: %gcc@6.0:') |
There was a problem hiding this comment.
perhaps you meant to to change plasma@develop into [email protected]: instead of changing the when= part.
| depends_on('[email protected]~int64+hypre', when='@develop') | ||
|
|
||
| depends_on('plasma@17.1', when='@develop %gcc@4.9:') | ||
| depends_on('plasma@17.2', when='@develop: %gcc@6.0:') |
There was a problem hiding this comment.
i guess you want
depends_on('[email protected]:', when='@develop %[email protected]:')
(17.2: will be satisfied by develop only). Otherwise Spack won't know how to satisfy this constraint.
balay
force-pushed
the
balay/xsdk-plasma-develop
branch
from
fc6e2ea to
c2fbd4a
Compare
|
I have a successful build on linux (gcc-8) and OSX (brew/gcc-8) so removing the 'don't-merge-yet' tag |
plasma@develop has another flag 'DHAVE_MKL' that needs to be disabled [for non-mkl build] add dependency on gcc-6.0 add in new dependency on readline plasma: requires both LIBS in make.inc and command line? If cmd line is missing -some internal values from plasma makefile gets used - causing link errors [on Mac] tools/lua-5.3.4/src/Makefile: $(MAKE) $(ALL) SYSCFLAGS="-DLUA_USE_LINUX" SYSLIBS="-Wl,-E -lreadline" if make.inc is missing - I get: /usr/bin/ld: cannot find -lmkl_intel_lp64 /usr/bin/ld: cannot find -lmkl_sequential /usr/bin/ld: cannot find -lmkl_core collect2: error: ld returned 1 exit status Also add a new dependency -ldl
balay
force-pushed
the
balay/xsdk-plasma-develop
branch
from
7284806 to
d985e4e
Compare
3 participants
plasma@develop has another flag 'DHAVE_MKL' that needs to be disabled [for non-mkl build]
add dependency on gcc-6.0