Add py-imageio for python3#8553
Conversation
s-sajid-ali
force-pushed
the
py_imageio_python_3
branch
from
94c69e4 to
1abd03a
Compare
|
Done. Changed the checksum to match the pypi version this time! |
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
Needs some flake8 changes:
var/spack/repos/builtin/packages/py-imageio/package.py:29: [W291] trailing whitespace
var/spack/repos/builtin/packages/py-imageio/package.py:30: [W291] trailing whitespace
var/spack/repos/builtin/packages/py-imageio/package.py:31: [W291] trailing whitespace
var/spack/repos/builtin/packages/py-imageio/package.py:39: [E265] block comment should start with '# '
var/spack/repos/builtin/packages/py-imageio/package.py:42: [E231] missing whitespace after ','
var/spack/repos/builtin/packages/py-imageio/package.py:47: [E303] too many blank lines (2)
Don't merge until concretizer can choose dependencies for python 2 vs 3. (Redundant dependencies can be added as a workaround if people need this.)
I don't see any reason not to merge this. Can you elaborate?
|
|
||
| def build_args(self, spec, prefix): | ||
| args = [] | ||
| return args |
There was a problem hiding this comment.
You can remove this function if you aren't going to use it.
| # Fix for python 2 if needed. | ||
| depends_on('py-numpy', type=('build','run')) | ||
| depends_on('py-pillow', type=('build', 'run')) | ||
| depends_on('ffmpeg', type='run') |
There was a problem hiding this comment.
Missing the following dependencies:
depends_on('[email protected]:2.8,3.4:', type=('build', 'run'))
depends_on('py-setuptools', type='build')
|
The setup.py from the github repo has this Since the last two depend on the version of python and spack can't pick dependencies based on python 2 vs 3, I stated that if someone is using python2 and wants this, they can add a depends on py-enum34 and py-futures as a stopgap until the concretizer is fixed. |
|
I see. Well the latest tarball doesn't have these restrictions, so I think we can ignore this problem for now. Hopefully the concretizer will be updated before someone needs to add a new release of |
|
I'm getting a strange error when I try to activate it. What causes this ? It worked fine with [email protected], but I re-built it because that ffmpeg didn't work and now imageio won't load. |
|
Even if I force it to activate the correct version by DAG, it won't work. Why is spack looking for the wrong dag ? Neither will it uninstall. Uninstalled from develop, removed the old module file and the problem still persists. |
This looks like a out-of-date database. Try running |
|
As per @adamjstewart , I tried Clean and re-index and still the same error : |
3 participants
Add new package py-imageio.
Don't merge until concretizer can choose dependencies for python 2 vs 3. (Redundant dependencies can be added as a workaround if people need this.)
Note:
https://pypi.io/packages/source/I/imageio/imageio-2.3.0.tar.gzdoes not work