Fix [email protected] on OS X 10.13.5#8540
Conversation
[email protected] failed to build on my OS X 10.13.5 box. I found/modified a patch in the MacPorts world that traced back to Homebrewy, https://trac.macports.org/ticket/56502#no1 The issue has also been reported to gcc, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83531 I eventually discovered a nearly identical version of the patch at Homebrew. https://github.com/Homebrew/formula-patches/blob/master/gcc%405/10.13_headers.patch gcc builds with this and I can compile many things, but e.g. curl and cmake both fail. As @davydden and others observed in spack#1847, it seems to be an apple thing.
| # https://trac.macports.org/ticket/56502#no1 | ||
| # see also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83531 | ||
| patch('darwin/headers-10.13-fix.patch', when='@5.5.0') | ||
| patch('darwin/gcc-7.1.0-headerpad.patch', when='@5') |
There was a problem hiding this comment.
I don't understand, does this patch not apply to newer versions of GCC? Based on the filename, it looks like it was originally created for GCC 7.1.0. Perhaps they fixed the problem in GCC 5.5.0? In that case, you would do something like:
patch('darwin/gcc-7.1.0-headerpad.patch', when='@5.0:5.4,6:')There was a problem hiding this comment.
I didn't intentionally change that line, I don't think. My change was to bump the minimum version for the darwin/apfs.patch and add the darwin/headers-10.13-fix.patch. I'll fix it and retest.
Good catch!
I've seen several versions of the headers-10... patch that appear to be for various versions, but I only tested it on [email protected] and very quickly came to realize that gcc on MacOS is an upstream swim.
There was a problem hiding this comment.
I replaced the missing :, [email protected] works as well as gcc ever seems to work on the mac (e.g. can't build curl...).
I mistakenly deleted a colon from the 'darwin/gcc-7.1.0-headerpad.patch'.
2 participants
[email protected] failed to build on my OS X 10.13.5 box.
I found/modified a patch in the MacPorts world that traced back to
Homebrew, https://trac.macports.org/ticket/56502#no1
The issue has also been reported to gcc,
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83531
I eventually discovered a nearly identical version of the patch at
Homebrew.
https://github.com/Homebrew/formula-patches/blob/master/gcc%405/10.13_headers.patch
gcc builds with this and I can compile many things, but e.g. curl and
cmake both fail. As @davydden and others observed in #1847, it seems
to be an apple thing.