Conversation
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
Does this work without a url_for_version? I don't know if spack is smart enough to replace the version in one place with periods and another with underscores.
|
|
||
| homepage = "https://root.cern.ch" | ||
| url = "https://root.cern.ch/download/root_v6.09.02.source.tar.gz" | ||
| list_url = "https://root.cern.ch/download/" |
There was a problem hiding this comment.
@paul-chelarescu I think this should not be on this PR.
|
|
||
| patch('sprintf.cxx.patch', when='@5.08.00:5.18.00') | ||
| patch('sprintf.patch', when='@:1.7.9') | ||
| patch('LASymMatrix.h.patch', when='@:1.7.6') |
There was a problem hiding this comment.
These versions don't exist in this PR.
There was a problem hiding this comment.
No, they are old versions whose checksum I haven't added
| version('5.08.00', '1cc8da07c4a247c877f39acf8d76ba02') | ||
|
|
||
| def url_for_version(self, version): | ||
| print version |
There was a problem hiding this comment.
Can you delete this line? It doesn't even work in Python 3.
| version('1.6.3', '955f560d0fb17bd7f081eddd7080fad6') | ||
| version('1.6.0', '6992d70fc8fded50be49b6b358b58507') | ||
| version('1.5.2', '31a0698febe59edd70aa001c4d7a56f8') | ||
| version('1.5.0', 'bc502c66af071fcdc0a2ae45a8740c75') |
There was a problem hiding this comment.
Out of curiosity, do you really need all of these versions? I usually only add the latest version. It makes it easier to maintain the package, as there are fewer versions to test when making changes.
There was a problem hiding this comment.
The current url configuration only allows the versions command to see the versions greater than 5 and this seems to be the only way to display the old versions which can be otherwise built successfully.
|
Thanks @paul-chelarescu, welcome to Spack! |
3 participants
No description provided.