Balay/petsc remove boost dependency#8508
Merged
adamjstewart merged 5 commits intodevelopfrom Jun 24, 2018
Merged
Conversation
… on trilinos Also set COPTFLAGS='' etc - this way CFLAGS is the primary way optimization flags are set by spack
davydden
approved these changes
Jun 19, 2018
Contributor
Author
I do not understand this error. @davydden, could you take a look at it? |
Member
|
Hm, don’t understand that either. Seems unrelated |
…[via trilinos] accordingly
Contributor
Author
|
@davydden I pushed one more change. Could you review that aswell? Thanks! |
Contributor
Author
|
Is this ready for a merge? |
| depends_on('metis@5:~int64', when='@3.8:+metis~int64') | ||
| depends_on('metis@5:+int64', when='@3.8:+metis+int64') | ||
| # trilinos might require boost | ||
| depends_on('boost', when='@3.7.0:+trilinos+boost') |
Member
There was a problem hiding this comment.
If that's the case, shouldn't trilinos depend on boost, not petsc?
Contributor
Author
There was a problem hiding this comment.
Hm - ok - many these lines are not needed.
The important thing here is the next set of changes
if 'trilinos' in spec:
options.append('--with-cxx-dialect=C++11')
- options.append('--with-boost=1')
+ if spec.satisfies('^trilinos+boost'):
+ options.append('--with-boost=1')
Will update PR
…rilinos adds this dependency anyway.
Contributor
Author
|
@adamjstewart is this PR also ready for merge? |
adamjstewart
approved these changes
Jun 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #8296