samrai: update package for 3.12.0 and fix compilation bugs for earlier versions#8501
Merged
adamjstewart merged 2 commits intospack:developfrom Jun 18, 2018
Merged
samrai: update package for 3.12.0 and fix compilation bugs for earlier versions#8501adamjstewart merged 2 commits intospack:developfrom
adamjstewart merged 2 commits intospack:developfrom
Conversation
…s, but keep the older versions ccontinuing working with boost 1.64.0 or earlier. Also, the older versions cannot compile with boost 1.65.0 or above. (spack#8491)
| # < 3.12.0 versions. I don't know what version of boost that | ||
| # happened at though without trying each version of boost. | ||
| depends_on('boost@:1.60.0', when='@0:3.11.99') | ||
| # From 3.12.0, samrai no long depends on boost. |
Member
There was a problem hiding this comment.
Typo: "long" -> "longer"
I would also switch "From" to "Starting with"
Contributor
Author
There was a problem hiding this comment.
Sure.
Should I resubmit a new PR?
Member
There was a problem hiding this comment.
Nah, just add a second commit to this PR.
| # From 3.12.0, samrai no long depends on boost. | ||
| # version 3.11.5 or earlier can only work with boost version | ||
| # 1.64.0 or earlier. | ||
| depends_on('boost@:1.64.0', when='@0:3.11.99', type='build') |
Member
There was a problem hiding this comment.
It doesn't link to any of the Boost libraries?
| env['CXXFLAGS'] = self.compiler.cxx11_flag | ||
| else: | ||
| # boost 1.64.0 or earlier works with samrai 2.4.4~3.11.5 | ||
| options.extend(['--with-boost=%s' % self.spec['boost'].prefix]) |
Member
There was a problem hiding this comment.
I would use options.append() instead of options.extend([]). No need to create an extra list.
Member
There was a problem hiding this comment.
Also, this is already being added above.
Contributor
Author
There was a problem hiding this comment.
The above one was intended to be removed.
if self.spec.satisfies('@0:3.11.99'):
options.extend([
'--with-boost=%s' % self.spec['boost'].prefix
])
adamjstewart
approved these changes
Jun 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SAMRAI: remove dependency on boost for samrai 3.12.0 or later versions, but keep the older versions continuing working with boost 1.64.0 or earlier. Also, the older versions cannot compile with boost 1.65.0 or above. (#8491)