Updates to Nalu package(s)#8492
Merged
adamjstewart merged 2 commits intospack:developfrom Jun 18, 2018
jrood-nrel:nalu_updates
Merged
Updates to Nalu package(s)#8492adamjstewart merged 2 commits intospack:developfrom jrood-nrel:nalu_updates
adamjstewart merged 2 commits intospack:developfrom
jrood-nrel:nalu_updates
Conversation
…the new Nalu-Wind wind energy focused application.
Member
Author
|
Uh oh, this is going to cause a small conflict with #8490 |
tgamblin
approved these changes
Jun 15, 2018
| homepage = "https://github.com/NaluCFD/Nalu" | ||
| url = "https://github.com/NaluCFD/Nalu.git" | ||
|
|
||
| maintainers = ['jrood-nrel'] |
Member
Author
There was a problem hiding this comment.
Nalu itself is on it's own. Nalu-Wind is what I'm supporting under ECP now.
| options.extend([ | ||
| '-DENABLE_HYPRE:BOOL=ON', | ||
| '-DHYPRE_DIR:PATH=%s' % spec['hypre'].prefix | ||
| ]) |
Member
There was a problem hiding this comment.
It might be a good idea to explicitly disable these dependencies in the else: case. I know a lot of CMake packages that pick up and install components if they can find their dependencies elsewhere on the OS.
| @@ -35,8 +35,6 @@ class Nalu(CMakePackage): | |||
| homepage = "https://github.com/NaluCFD/Nalu" | |||
Member
There was a problem hiding this comment.
Might want to remove "Wind ECP" from the docstring now that it has its own package.
adamjstewart
approved these changes
Jun 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a new version of Nalu, called Nalu-Wind, for our exascale project that I am adding with this pull request. I am also updating Nalu to allow for building with shared libraries. They also don't build against anything but the
masteranddevelopbranches of Trilinos for the foreseeable future.