Skip to content

[mfem] Add BLAS+LAPACK to the required dependencies of SuperLU_DIST#8485

Merged
alalazo merged 1 commit intodevelopfrom
v-dobrev/mfem-link-opts-fix
Jun 15, 2018
Merged

[mfem] Add BLAS+LAPACK to the required dependencies of SuperLU_DIST#8485
alalazo merged 1 commit intodevelopfrom
v-dobrev/mfem-link-opts-fix

Conversation

@v-dobrev
Copy link
Copy Markdown
Member

@v-dobrev v-dobrev commented Jun 14, 2018

This should resolve an issue encountered when building xsdk@develop.

@v-dobrev v-dobrev added bug Something isn't working build-error linking xSDK labels Jun 14, 2018
@v-dobrev v-dobrev self-assigned this Jun 14, 2018
@v-dobrev v-dobrev requested review from acfisher, balay and tzanio June 14, 2018 20:57
@v-dobrev
Copy link
Copy Markdown
Member Author

v-dobrev commented Jun 15, 2018

The travis failure seems unrelated to this PR. I reran the failed test and it failed again. The checksum error for openssl that causes the test to fail seems real - other PRs seem to have the same issue.

@tgamblin, could this be caused by corrupt cached copy of the opensll tarball?

balay
balay approved these changes Jun 15, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@balay balay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change works for me - so can be merged in.

For long term - I wish all code that deals with creating (library) link lines do this in the correct library link order.

i.e '-lhypre -lblas -lsuperlu_dist -lblas -lpetsc' works with shared libraries - but not really correct.

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Jun 15, 2018

For long term - I wish all code that deals with creating (library) link lines do this in the correct library link order.

@balay For what is worth LibraryList is designed to preserve the order of libraries, so it should just be a matter of fixing the construction of the objects in client code (i.e. in the package recipes).

@alalazo alalazo merged commit a3c989e into develop Jun 15, 2018
@alalazo alalazo deleted the v-dobrev/mfem-link-opts-fix branch June 15, 2018 09:34
@tzanio tzanio mentioned this pull request Jun 15, 2018
Closed
smuething added a commit to smuething/spack that referenced this pull request Jun 18, 2018
@smuething
Merge branch 'upstream-develop' into develop
72f18f6 
* upstream-develop: (430 commits)
  There's only one 'u' in "configuration" (spack#8498)
  Add new versions for TAU and PDT package (spack#8497)
  Add changes to the Krell packages with version updates and ranges for  the latest release. (spack#8468)
  docs: remove vendored sphinx_rtd_theme (spack#8496)
  Trilinos needs parallel-netcdf as an explicit dependency to avoid concretization errors when netcdf is an external. (spack#8493)
  superlu_dist: 'master' is branch - not tag (spack#8495)
  SAMRAI: new versions, handle deprecation of boost in latest version. (spack#8494)
  Fix GDAL Python bindings and add import tests (spack#8482)
  Add newer likwid versions 4.3.1 and 4.3.2 (spack#8488)
  Package/geopm: Update to version 0.5.0 (spack#8487)
  [mfem] Add BLAS+LAPACK to the required dependencies of SuperLU_DIST. (spack#8485)
  openssl: add new version 1.0.2o (spack#8486)
  Update the clang compiler definition to use IBM XL Fortran compiler (spack#8389)
  Patch trilinos for xlf when using clang (spack#8391)
  Use no mangling for all spack compiler definitions that use the XL (spack#8392)
  Use the name of the Fortran compiler to determine what name mangling (spack#8393)
  A new package: megahit. (spack#8471)
  neovim: add info for v0.3.0 (spack#8472)
  oce: add 0.18.3 (spack#8477)
  netgen should depend on zlib (spack#8473)
  ...
smuething added a commit to smuething/spack that referenced this pull request Jun 18, 2018
@smuething
Merge branch 'upstream-develop' into develop
5b5e524 
* upstream-develop: (430 commits)
  There's only one 'u' in "configuration" (spack#8498)
  Add new versions for TAU and PDT package (spack#8497)
  Add changes to the Krell packages with version updates and ranges for  the latest release. (spack#8468)
  docs: remove vendored sphinx_rtd_theme (spack#8496)
  Trilinos needs parallel-netcdf as an explicit dependency to avoid concretization errors when netcdf is an external. (spack#8493)
  superlu_dist: 'master' is branch - not tag (spack#8495)
  SAMRAI: new versions, handle deprecation of boost in latest version. (spack#8494)
  Fix GDAL Python bindings and add import tests (spack#8482)
  Add newer likwid versions 4.3.1 and 4.3.2 (spack#8488)
  Package/geopm: Update to version 0.5.0 (spack#8487)
  [mfem] Add BLAS+LAPACK to the required dependencies of SuperLU_DIST. (spack#8485)
  openssl: add new version 1.0.2o (spack#8486)
  Update the clang compiler definition to use IBM XL Fortran compiler (spack#8389)
  Patch trilinos for xlf when using clang (spack#8391)
  Use no mangling for all spack compiler definitions that use the XL (spack#8392)
  Use the name of the Fortran compiler to determine what name mangling (spack#8393)
  A new package: megahit. (spack#8471)
  neovim: add info for v0.3.0 (spack#8472)
  oce: add 0.18.3 (spack#8477)
  netgen should depend on zlib (spack#8473)
  ...
smuething added a commit to smuething/spack that referenced this pull request Jun 18, 2018
@smuething
Merge branch 'upstream-develop' into develop
29637a7 
* upstream-develop: (430 commits)
  There's only one 'u' in "configuration" (spack#8498)
  Add new versions for TAU and PDT package (spack#8497)
  Add changes to the Krell packages with version updates and ranges for  the latest release. (spack#8468)
  docs: remove vendored sphinx_rtd_theme (spack#8496)
  Trilinos needs parallel-netcdf as an explicit dependency to avoid concretization errors when netcdf is an external. (spack#8493)
  superlu_dist: 'master' is branch - not tag (spack#8495)
  SAMRAI: new versions, handle deprecation of boost in latest version. (spack#8494)
  Fix GDAL Python bindings and add import tests (spack#8482)
  Add newer likwid versions 4.3.1 and 4.3.2 (spack#8488)
  Package/geopm: Update to version 0.5.0 (spack#8487)
  [mfem] Add BLAS+LAPACK to the required dependencies of SuperLU_DIST. (spack#8485)
  openssl: add new version 1.0.2o (spack#8486)
  Update the clang compiler definition to use IBM XL Fortran compiler (spack#8389)
  Patch trilinos for xlf when using clang (spack#8391)
  Use no mangling for all spack compiler definitions that use the XL (spack#8392)
  Use the name of the Fortran compiler to determine what name mangling (spack#8393)
  A new package: megahit. (spack#8471)
  neovim: add info for v0.3.0 (spack#8472)
  oce: add 0.18.3 (spack#8477)
  netgen should depend on zlib (spack#8473)
  ...
smuething added a commit to smuething/spack that referenced this pull request Jun 18, 2018
@smuething
Merge branch 'upstream-develop' into develop
8b2f529 
* upstream-develop: (430 commits)
  There's only one 'u' in "configuration" (spack#8498)
  Add new versions for TAU and PDT package (spack#8497)
  Add changes to the Krell packages with version updates and ranges for  the latest release. (spack#8468)
  docs: remove vendored sphinx_rtd_theme (spack#8496)
  Trilinos needs parallel-netcdf as an explicit dependency to avoid concretization errors when netcdf is an external. (spack#8493)
  superlu_dist: 'master' is branch - not tag (spack#8495)
  SAMRAI: new versions, handle deprecation of boost in latest version. (spack#8494)
  Fix GDAL Python bindings and add import tests (spack#8482)
  Add newer likwid versions 4.3.1 and 4.3.2 (spack#8488)
  Package/geopm: Update to version 0.5.0 (spack#8487)
  [mfem] Add BLAS+LAPACK to the required dependencies of SuperLU_DIST. (spack#8485)
  openssl: add new version 1.0.2o (spack#8486)
  Update the clang compiler definition to use IBM XL Fortran compiler (spack#8389)
  Patch trilinos for xlf when using clang (spack#8391)
  Use no mangling for all spack compiler definitions that use the XL (spack#8392)
  Use the name of the Fortran compiler to determine what name mangling (spack#8393)
  A new package: megahit. (spack#8471)
  neovim: add info for v0.3.0 (spack#8472)
  oce: add 0.18.3 (spack#8477)
  netgen should depend on zlib (spack#8473)
  ...
nrichart pushed a commit to epfl-scitas/spack that referenced this pull request Oct 22, 2018
@v-dobrev @nrichart
[mfem] Add BLAS+LAPACK to the required dependencies of SuperLU_DIST. (s…
f56882c 
…pack#8485)
@nrichart nrichart mentioned this pull request Oct 22, 2018
Merged
rmsds pushed a commit to epfl-scitas/spack that referenced this pull request Nov 15, 2018
@nrichart @rmsds
Cherry picking changes upstream for mfem (#207)
05f3407 
* [mfem] new version: 3.4 (spack#8453)

* Add new version (3.4.0) with new variant (pumi).
* Fix an issue: skip the tests in examples/pumi as they require
files that are not included in the mfem distribution/repository.
* Use patches to fix the testing issues with PUMI and PETSc v3.9.
* Use the new bit.ly short link for v3.4.

* [mfem] Add BLAS+LAPACK to the required dependencies of SuperLU_DIST. (spack#8485)

* mfem: mfem-3.3-3.4-petsc-3.9.patch is not needed for latest develop version (spack#8809)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tzanio tzanio tzanio approved these changes

@alalazo alalazo alalazo approved these changes

@balay balay balay approved these changes

@acfisher acfisher Awaiting requested review from acfisher

+1 more reviewer

@davydden davydden davydden approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@v-dobrev v-dobrev

Labels

bug Something isn't working build-error xSDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@v-dobrev @alalazo @tzanio @balay @davydden