Add changes to the Krell packages with version updates and ranges for the latest release.#8468
Merged
adamjstewart merged 3 commits intospack:developfrom Jun 17, 2018
Merged
Conversation
… the latest release.
|
|
||
| version('1.3.0.0', branch='1.3.0.0', | ||
| git='https://github.com/OpenSpeedShop/cbtf-argonavis-gui.git') | ||
| git='https://github.com/OpenSpeedShop/cbtf-argonavis-gui.git', preferred=True) |
Member
There was a problem hiding this comment.
This change shouldn't be necessary, Spack should already be choosing 1.3.0.0 by default.
Contributor
Author
There was a problem hiding this comment.
I think it was picking 1.3.0.0 as you say without the preferred, but spack was not following the same path as if the preferred statement clause is present. The build was getting concretization errors without the preferred clause.
|
|
||
| depends_on('[email protected]:', when='@develop') | ||
| depends_on('[email protected]', when='@1.3.0.0:') | ||
| depends_on('[email protected]', when='@1.3.0.0:9999') |
Member
There was a problem hiding this comment.
I've always been confused by the dependencies in this package. It seems like the develop version supports older versions of dependencies than the latest release? It's usually the other way around...
Contributor
Author
There was a problem hiding this comment.
We wanted to go with a proven path for the release versions and let spack pick the latest version available for develop. I could make the develop version start at a higher level qt version.
Contributor
Author
There was a problem hiding this comment.
@adamjstewart I will update the qt develop version asked for.
| # Use when the git repository is available | ||
| version('2.3.1.4', branch='2.3.1.4', | ||
| git='https://github.com/OpenSpeedShop/openspeedshop.git') | ||
| git='https://github.com/OpenSpeedShop/openspeedshop.git', preferred=True) |
Member
There was a problem hiding this comment.
This should already be the default version, no need for this change.
Contributor
Author
There was a problem hiding this comment.
Same as above:
I think it was picking 2.3.1.4 as you say without the preferred, but spack was not following the same path as if the preferred statement clause is present. The build was getting concretization errors without the preferred clause.
Contributor
Author
There was a problem hiding this comment.
@adamjstewart I will retest this and the cbtf-argonavis-gui one too.
…he qt version for the cbtf-argonavis-gui@develop
Contributor
Author
|
@adamjstewart I updated the files to reflect your comments and suggestions. Thanks! |
adamjstewart
approved these changes
Jun 15, 2018
Member
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
I'm still not sure I understand any of the dependency version requirements, but they're your packages.
smuething
added a commit
to smuething/spack
that referenced
this pull request
Jun 18, 2018
* upstream-develop: (430 commits) There's only one 'u' in "configuration" (spack#8498) Add new versions for TAU and PDT package (spack#8497) Add changes to the Krell packages with version updates and ranges for the latest release. (spack#8468) docs: remove vendored sphinx_rtd_theme (spack#8496) Trilinos needs parallel-netcdf as an explicit dependency to avoid concretization errors when netcdf is an external. (spack#8493) superlu_dist: 'master' is branch - not tag (spack#8495) SAMRAI: new versions, handle deprecation of boost in latest version. (spack#8494) Fix GDAL Python bindings and add import tests (spack#8482) Add newer likwid versions 4.3.1 and 4.3.2 (spack#8488) Package/geopm: Update to version 0.5.0 (spack#8487) [mfem] Add BLAS+LAPACK to the required dependencies of SuperLU_DIST. (spack#8485) openssl: add new version 1.0.2o (spack#8486) Update the clang compiler definition to use IBM XL Fortran compiler (spack#8389) Patch trilinos for xlf when using clang (spack#8391) Use no mangling for all spack compiler definitions that use the XL (spack#8392) Use the name of the Fortran compiler to determine what name mangling (spack#8393) A new package: megahit. (spack#8471) neovim: add info for v0.3.0 (spack#8472) oce: add 0.18.3 (spack#8477) netgen should depend on zlib (spack#8473) ...
smuething
added a commit
to smuething/spack
that referenced
this pull request
Jun 18, 2018
* upstream-develop: (430 commits) There's only one 'u' in "configuration" (spack#8498) Add new versions for TAU and PDT package (spack#8497) Add changes to the Krell packages with version updates and ranges for the latest release. (spack#8468) docs: remove vendored sphinx_rtd_theme (spack#8496) Trilinos needs parallel-netcdf as an explicit dependency to avoid concretization errors when netcdf is an external. (spack#8493) superlu_dist: 'master' is branch - not tag (spack#8495) SAMRAI: new versions, handle deprecation of boost in latest version. (spack#8494) Fix GDAL Python bindings and add import tests (spack#8482) Add newer likwid versions 4.3.1 and 4.3.2 (spack#8488) Package/geopm: Update to version 0.5.0 (spack#8487) [mfem] Add BLAS+LAPACK to the required dependencies of SuperLU_DIST. (spack#8485) openssl: add new version 1.0.2o (spack#8486) Update the clang compiler definition to use IBM XL Fortran compiler (spack#8389) Patch trilinos for xlf when using clang (spack#8391) Use no mangling for all spack compiler definitions that use the XL (spack#8392) Use the name of the Fortran compiler to determine what name mangling (spack#8393) A new package: megahit. (spack#8471) neovim: add info for v0.3.0 (spack#8472) oce: add 0.18.3 (spack#8477) netgen should depend on zlib (spack#8473) ...
smuething
added a commit
to smuething/spack
that referenced
this pull request
Jun 18, 2018
* upstream-develop: (430 commits) There's only one 'u' in "configuration" (spack#8498) Add new versions for TAU and PDT package (spack#8497) Add changes to the Krell packages with version updates and ranges for the latest release. (spack#8468) docs: remove vendored sphinx_rtd_theme (spack#8496) Trilinos needs parallel-netcdf as an explicit dependency to avoid concretization errors when netcdf is an external. (spack#8493) superlu_dist: 'master' is branch - not tag (spack#8495) SAMRAI: new versions, handle deprecation of boost in latest version. (spack#8494) Fix GDAL Python bindings and add import tests (spack#8482) Add newer likwid versions 4.3.1 and 4.3.2 (spack#8488) Package/geopm: Update to version 0.5.0 (spack#8487) [mfem] Add BLAS+LAPACK to the required dependencies of SuperLU_DIST. (spack#8485) openssl: add new version 1.0.2o (spack#8486) Update the clang compiler definition to use IBM XL Fortran compiler (spack#8389) Patch trilinos for xlf when using clang (spack#8391) Use no mangling for all spack compiler definitions that use the XL (spack#8392) Use the name of the Fortran compiler to determine what name mangling (spack#8393) A new package: megahit. (spack#8471) neovim: add info for v0.3.0 (spack#8472) oce: add 0.18.3 (spack#8477) netgen should depend on zlib (spack#8473) ...
smuething
added a commit
to smuething/spack
that referenced
this pull request
Jun 18, 2018
* upstream-develop: (430 commits) There's only one 'u' in "configuration" (spack#8498) Add new versions for TAU and PDT package (spack#8497) Add changes to the Krell packages with version updates and ranges for the latest release. (spack#8468) docs: remove vendored sphinx_rtd_theme (spack#8496) Trilinos needs parallel-netcdf as an explicit dependency to avoid concretization errors when netcdf is an external. (spack#8493) superlu_dist: 'master' is branch - not tag (spack#8495) SAMRAI: new versions, handle deprecation of boost in latest version. (spack#8494) Fix GDAL Python bindings and add import tests (spack#8482) Add newer likwid versions 4.3.1 and 4.3.2 (spack#8488) Package/geopm: Update to version 0.5.0 (spack#8487) [mfem] Add BLAS+LAPACK to the required dependencies of SuperLU_DIST. (spack#8485) openssl: add new version 1.0.2o (spack#8486) Update the clang compiler definition to use IBM XL Fortran compiler (spack#8389) Patch trilinos for xlf when using clang (spack#8391) Use no mangling for all spack compiler definitions that use the XL (spack#8392) Use the name of the Fortran compiler to determine what name mangling (spack#8393) A new package: megahit. (spack#8471) neovim: add info for v0.3.0 (spack#8472) oce: add 0.18.3 (spack#8477) netgen should depend on zlib (spack#8473) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add changes to the Krell packages with version updates and ranges for the latest release. Change the ranges on versions, so the packages don't have to change as much when a new release is made. Also, the changes allows the development version of OpenSpeedShop to use the develop version of Dyninst.