Change MUMPS to allow it to build with clang+xlf compiler combination#8388
Merged
scheibelp merged 6 commits intospack:developfrom Aug 2, 2018
Merged
Change MUMPS to allow it to build with clang+xlf compiler combination#8388scheibelp merged 6 commits intospack:developfrom
scheibelp merged 6 commits intospack:developfrom
Conversation
Changed how to determine if xlf is used and patched examples.
davydden
approved these changes
Jun 5, 2018
| # working only for intel and gnu compilers this is | ||
| # perhaps something the compiler should provide | ||
| ['OPTF = %s -O -DALLOW_NON_INIT %s' % (fpic, '-fdefault-integer-8' if self.compiler.name == "gcc" else '-i8'), # noqa | ||
| 'OPTL = %s -O ' % fpic, |
Member
There was a problem hiding this comment.
So you changed from -O to -O3 here?
Contributor
Author
There was a problem hiding this comment.
Yes. As we have been using -O3 for the XL compiler suite, it felt appropriate to use -O3 for llvm Fortran when its being compiled by xlf.
Member
There was a problem hiding this comment.
But I meant OPTL and OPTC that are now outside of the if-xl-else branch.
Contributor
Author
There was a problem hiding this comment.
@davydden Thats an oversight. I'll push an update.
Member
There was a problem hiding this comment.
is this fixed?
i think so, there opt_level variable that is used.
Contributor
Author
davydden
approved these changes
Jun 6, 2018
Contributor
Author
|
@adamjstewart @alalazo -- would either of you be willing to merge this PR? |
This was referenced Jun 12, 2018
Contributor
Author
|
Fixed the flake8 errors I was getting |
Contributor
Author
|
@tgamblin Would you be willing to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mumpspackage was unable to build using the llvmclangcompiler suite, as it defaulted to usingmpif90for linking andmpif90cannot be used for linking shared library code. This PR modifies the MUMPSpackage.pyto allow it to use IBM XL Fortran for linking. It also eliminates the need for the existing MUMPS IBM XL patches by having package.py` specify a the compiler-dependent "shared" flag to the linker, and always using the compiler suite's Fortran compiler for linking.