Support version 4.10.2-bsd#8164
Merged
adamjstewart merged 1 commit intospack:developfrom May 18, 2018
DarylGrunau:packages/silo
Merged
Support version 4.10.2-bsd#8164adamjstewart merged 1 commit intospack:developfrom DarylGrunau:packages/silo
adamjstewart merged 1 commit intospack:developfrom
DarylGrunau:packages/silo
Conversation
Contributor
Author
|
Closing this PR because one of the tests timed out as it ran. |
healther
approved these changes
May 17, 2018
Contributor
Author
|
Sorry, perhaps I should not have closed this but I saw (non-fatal) errors in the status so I assumed the pull request would not be accepted. @healther by my closing does that invalidate the PR so I should re-try? Thanks for any info! |
adamjstewart
approved these changes
May 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the version of Silo that our code team uses. Since Spack sorts this version to become the new preferred default, I list "preferred=True" on version 4.10.2 so that the original default is kept. Note that the URL specification is necessary because this version of Silo is not kept in a standard location that the others are :(