Merged
Conversation
healther
reviewed
May 17, 2018
|
|
||
| def setup_environment(self, spack_env, run_env): | ||
| spec = self.spec | ||
| spack_env.set('NETCDF_INC', spec['netcdf'].prefix.include) |
Contributor
There was a problem hiding this comment.
the question is: Should this be done by the netcdf package? This looks like it could be a commonly used idiom, but my understanding of auto tools is too limited to have a firm opinion.
Contributor
There was a problem hiding this comment.
With the same going for the other dependencies
Member
Author
|
The NETCDF_INC variable is specific to NCO.
…On Thu, May 17, 2018 at 7:22 AM, healther ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In var/spack/repos/builtin/packages/nco/package.py:
> @@ -60,3 +60,10 @@ class Nco(AutotoolsPackage):
def configure_args(self):
spec = self.spec
return ['--{0}-doc'.format('enable' if '+doc' in spec else 'disable')]
+
+ def setup_environment(self, spack_env, run_env):
+ spec = self.spec
+ spack_env.set('NETCDF_INC', spec['netcdf'].prefix.include)
the question is: Should this be done by the netcdf package? This looks
like it could be a commonly used idiom, but my understanding of auto tools
is too limited to have a firm opinion.
------------------------------
In var/spack/repos/builtin/packages/nco/package.py:
> @@ -60,3 +60,10 @@ class Nco(AutotoolsPackage):
def configure_args(self):
spec = self.spec
return ['--{0}-doc'.format('enable' if '+doc' in spec else 'disable')]
+
+ def setup_environment(self, spack_env, run_env):
+ spec = self.spec
+ spack_env.set('NETCDF_INC', spec['netcdf'].prefix.include)
With the same going for the other dependencies
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8159 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB1cd32tSfRUPq14_TkAig_rUpzxfG8lks5tzV2IgaJpZM4UBrNA>
.
|
adamjstewart
approved these changes
May 17, 2018
healther
approved these changes
May 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
ncowas not able to find Spack-installed NetCDF; presumably relying on system-installed NetCDF instead. If no system-installed NetCDF, this resulted in the error below. This PR fixes the problem.Note features and influential env variables for the NetCDF build: