trinity: fixing jdk dependency#8140
Merged
adamjstewart merged 1 commit intospack:developfrom May 18, 2018
Merged
Conversation
| version('2.6.6', 'b7472e98ab36655a6d9296d965471a56') | ||
|
|
||
| depends_on("jdk@8") | ||
| depends_on("java@8:") |
Member
There was a problem hiding this comment.
java@8 might actually work, that's how the provides command is written. Does this package only work with Java 8 or will it work with Java 9 too?
Member
Author
There was a problem hiding this comment.
I have not tested with java 9, but assume it will probably work
adamjstewart
approved these changes
May 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
due to jdk's goofy version numbers, the minor version parsing seems to break without trailing colon
Also changing to java virtual dependency instead of jdk explicitly