libexpat: Fix for older systems, move to GitHub#8135
Merged
adamjstewart merged 3 commits intospack:developfrom May 18, 2018
Merged
libexpat: Fix for older systems, move to GitHub#8135adamjstewart merged 3 commits intospack:developfrom
adamjstewart merged 3 commits intospack:developfrom
Conversation
…rsion of libexpat did. Also update for Expat's move to GitHub.
| version('2.2.2', '1ede9a41223c78528b8c5d23e69a2667', | ||
| url='https://github.com/libexpat/libexpat/releases/download/R_2_2_2/expat-2.2.2.tar.bz2') | ||
| version('2.2.0', '2f47841c829facb346eb6e3fab5212e2', | ||
| url='https://github.com/libexpat/libexpat/releases/download/R_2_2_0/expat-2.2.0.tar.bz2') |
Member
There was a problem hiding this comment.
You should be able to write a url_for_version to handle this:
def url_for_version(self, version):
url = 'https://github.com/libexpat/libexpat/releases/download/R_{0}/expat-{1}.tar.bz2'
return url.format(version.underscored, version.dotted)
Move to url_for_version()
adamjstewart
approved these changes
May 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On SuSE (SLES) 11, I got the following error, in spite of using
--with-libbsdas added in #4945:spack-build.out.txt
An update to the latest version of
libexpatsolved the problem. In the meantime, I'm moving this package to GitHub, as per instructions on the upstream website https://sourceforge.net/projects/expat/