Add cmake for newer version of libjpeg-turbo#8102
Merged
adamjstewart merged 8 commits intospack:developfrom May 14, 2018
Merged
Add cmake for newer version of libjpeg-turbo#8102adamjstewart merged 8 commits intospack:developfrom
adamjstewart merged 8 commits intospack:developfrom
Conversation
s-sajid-ali
changed the title
adamjstewart
requested changes
May 13, 2018
| @when('@:1.5.3') | ||
| def install(self, spec, prefix): | ||
| configure('--prefix=%s' % prefix) | ||
| make |
Member
There was a problem hiding this comment.
These should be make(), it's a function, not a statement.
| library that implements JPEG image encoding, decoding and | ||
| transcoding.""" | ||
| # https://github.com/libjpeg-turbo/libjpeg-turbo/blob/master/BUILDING.md | ||
| homepage = "https://github.com/libjpeg-turbo/libjpeg-turbo" |
Member
There was a problem hiding this comment.
I would actually use https://libjpeg-turbo.org/ as the homepage. That's what the previous homepage redirects to.
Contributor
Author
There was a problem hiding this comment.
For some reason the building instructions for the 1.6.x was broken from there but that's fine.
adamjstewart
approved these changes
May 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer version uses of libjpeg-turbo uses cmake.