Skip to content

Fix module_cmd finding for zsh#7884

Closed
EmreAtes wants to merge 3 commits intospack:developfrom
EmreAtes:develop
Closed

Fix module_cmd finding for zsh#7884
EmreAtes wants to merge 3 commits intospack:developfrom
EmreAtes:develop

Conversation

@EmreAtes
Copy link
Copy Markdown
Contributor

@EmreAtes EmreAtes commented Apr 24, 2018

I'm running spack on a system with zsh and the module function is as follows:

$ typeset -f module | envsubst
module () {
	eval `/usr/local/Modules/3.2.10/bin/modulecmd zsh $*`
}

The current regex cannot process this.

@EmreAtes
Copy link
Copy Markdown
Contributor Author

EmreAtes commented Apr 25, 2018

I added the universal_newlines parameter in the last commit, because without the parameter popen returns a byte-string, and re doesn't work with byte strings if the search string is not a byte string.

@skosukhin skosukhin mentioned this pull request Apr 26, 2018
Closed
@becker33 becker33 mentioned this pull request Jul 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

modules shell-support

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EmreAtes @tgamblin @adamjstewart