Skip to content

spack environment (2): expose a subset of packages to a user#7843

Closed
citibeth wants to merge 132 commits intodevelopfrom
features/context
Closed

spack environment (2): expose a subset of packages to a user#7843
citibeth wants to merge 132 commits intodevelopfrom
features/context

Conversation

@citibeth
Copy link
Copy Markdown
Member

This is a continuation of #4585, moving the branch into the main Spack repo. My latest commits have fixed bugs that became apparent in trying to use Spack Environments.

scheibelp added 30 commits May 30, 2017 16:12
… and writes stop early if an inconcistency is detected
…d the Spec back, all the build deps are present)
…esn't prevent it from appearing multiple times as a dependency)
…package to the context repo if it is already there

.. note::

Currently, only "bare" user specs may be added to an environment,
Copy link
Copy Markdown
Member

@scheibelp scheibelp May 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@citibeth this was supposed to be fixed by d537b69. Does it still not work for you?

EDIT: from my own checks this appears to work fine.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I removed the text.

scheibelp added 2 commits May 9, 2018 17:46
…kage repository; this enables use of the environment-maintained package repository at the highest precedence (so e.g. 'spack env concretize' will use package definitions stored in the environment)
@scheibelp
Copy link
Copy Markdown
Member

Suppose I have package builtin:P. When that package gets copied into the environment's repo, it should maintain the same name builtin:P. It shouldn't suddenly change namespace.

I thought from our discussion that this issue was acceptable since the --use-env-repo was off by default: the idea is that normally you can reconcretize as much as you want and the dag hashes are preserved but if you copy the environment directory to another spack instance you can reconcretize with the packages maintained in the environment. Or is this an additional issue I overlooked?

@citibeth
Copy link
Copy Markdown
Member Author

citibeth commented May 10, 2018 via email

@citibeth
Copy link
Copy Markdown
Member Author

I just checked over the whole PR. Looks good to me, let's get this merged please!

@scheibelp
Copy link
Copy Markdown
Member

@tgamblin @becker33 this is ready for review

@citibeth
Copy link
Copy Markdown
Member Author

Superceded by #8231

@citibeth citibeth closed this May 27, 2018
@tgamblin tgamblin reopened this Jan 1, 2020
@tgamblin tgamblin closed this Jan 1, 2020
@tgamblin tgamblin deleted the features/context branch January 1, 2020 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants