openmpi: libfabric support, ucx cleanup#7842
Merged
adamjstewart merged 2 commits intospack:developfrom Apr 25, 2018
Merged
Conversation
baberlevi
commented
Apr 19, 2018
| patch('configure.patch', when="@1.10.1") | ||
| patch('fix_multidef_pmi_class.patch', when="@2.0.0:2.0.1") | ||
|
|
||
| fabrics = ('psm', 'psm2', 'verbs', 'mxm', 'ucx', 'libfabric') |
Member
Author
There was a problem hiding this comment.
adds support for libfabric and ucx and makes fabrics a variable that can be used in when decorators below
baberlevi
commented
Apr 19, 2018
| variant('thread_multiple', default=False, | ||
| description='Enable MPI_THREAD_MULTIPLE support') | ||
| variant('cuda', default=False, description='Enable CUDA support') | ||
| variant('ucx', default=False, description='Enable UCX support') |
Member
Author
There was a problem hiding this comment.
is a fabric type, moved there
baberlevi
commented
Apr 19, 2018
| provides('mpi@:3.0', when='@1.7.5:') | ||
| provides('mpi@:3.1', when='@2.0.0:') | ||
|
|
||
| if sys.platform != 'darwin': |
Member
Author
There was a problem hiding this comment.
numactl not supported on Mac, but is required on linux. Has been pulling system version in
baberlevi
commented
Apr 19, 2018
| depends_on('ucx', when='+ucx') | ||
| depends_on('zlib', when='@3.0.0:') | ||
| depends_on('valgrind~mpi', when='+memchecker') | ||
| depends_on('ucx', when='fabrics=ucx') |
Member
Author
There was a problem hiding this comment.
dependency when clause changed to reflect ucx moving to fabrics list
baberlevi
commented
Apr 19, 2018
| depends_on('zlib', when='@3.0.0:') | ||
| depends_on('valgrind~mpi', when='+memchecker') | ||
| depends_on('ucx', when='fabrics=ucx') | ||
| depends_on('libfabric', when='fabrics=libfabric') |
Member
Author
There was a problem hiding this comment.
new dependency for libfabric
baberlevi
commented
Apr 19, 2018
| else: | ||
| config_args.append('--without-cuda') | ||
|
|
||
| # UCX support |
Member
Author
There was a problem hiding this comment.
now handled by with_or_without('fabrics')
adamjstewart
approved these changes
Apr 21, 2018
| default=None if _verbs_dir() is None else 'verbs', | ||
| description='List of fabrics that are enabled', | ||
| values=('psm', 'psm2', 'verbs', 'mxm'), | ||
| description=("List of fabrics that are enabled"), |
Member
Author
There was a problem hiding this comment.
I really don't remember why I did that. Removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This separates the changes for openmpi from #6978 and integrates with latest changes from develop.