Conversation
| version('1.6.0', '0441aa0aeda391b1bf1eb71250a4afbc') | ||
| version('1.5.3', 'f60cb95843ebf62e4eaa128e08ccdc7d') | ||
|
|
||
| depends_on('autoconf', type='build') |
There was a problem hiding this comment.
these should be part of the AutoToolsPackage
There was a problem hiding this comment.
They seem required (test below with them removed):
==> Executing phase: 'autoreconf'
==> Error: RuntimeError: Cannot generate configure: missing dependencies ['m4', 'autoconf', 'automake', 'libtool']
RuntimeError: RuntimeError: Cannot generate configure: missing dependencies ['m4', 'autoconf', 'automake', 'libtool']
/home/user/spack/lib/spack/spack/build_systems/autotools.py:200, in autoreconf:
7 missing = [x for x in autotools if x not in spec]
8 if missing:
9 msg = 'Cannot generate configure: missing dependencies {0}'
>> 10 raise RuntimeError(msg.format(missing))
11 tty.msg('Configure script not found: trying to generate it')
12 tty.warn('*********************************************************')
13 tty.warn('* If the default procedure fails, consider implementing *')
There was a problem hiding this comment.
Mh okay then I don't know enough about Autotools to review this.. Sorry for the confusion.
|
fixing some other issues that I found while testing the depenencies - another commit coming shortly |
healther
left a comment
healther
left a comment
There was a problem hiding this comment.
removing my change request
| """Fabtests provides a set of examples that uses libfabric""" | ||
|
|
||
| homepage = "http://libfabric.org" | ||
| url = "https://github.com/ofiwg/fabtests/archive/v1.5.3.tar.gz" |
There was a problem hiding this comment.
If you download from https://github.com/ofiwg/fabtests/releases/download/v1.5.3/fabtests-1.5.3.tar.gz instead of https://github.com/ofiwg/fabtests/archive/v1.5.3.tar.gz you can drop all of the Autotools dependencies. GitHub usually creates a source tarball with each release, and developers have the option of uploading their own tarball that contains generated files like configure. This way, the package has fewer dependencies and can be installed more quickly.
There was a problem hiding this comment.
Changed, reinstalled - confirmed working without the extra autotools deps
| url = "https://github.com/ofiwg/fabtests/archive/v1.5.3.tar.gz" | ||
|
|
||
| version('1.6.0', 'ac4808d11103fd29fc738bc2bfd919de') | ||
| version('1.5.3', 'a80b4741f5885a97983259d045f9865c') |
There was a problem hiding this comment.
Can you remove these extra spaces?
3 participants
breaking up #6978