Merged
Conversation
| url = "https://github.com/intel/psm/archive/v3.3.tar.gz" | ||
|
|
||
| version('3.3', '031eb27688c932867d55054e76d00875') | ||
| version('2017-04-28', git='https://github.com/intel/psm.git', commit='604758e') |
Member
There was a problem hiding this comment.
Which version does this default to? I'm guessing the 2017 version? We might want to add preferred=True to the latest stable release to override this.
Member
Author
There was a problem hiding this comment.
Yeah, it was defaulting to the 2017 version. Updated as you suggested
adamjstewart
approved these changes
Apr 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on PR #6978
breaking up into smaller PRs