Merged
Conversation
This was referenced Apr 19, 2018
Merged
| def check_platform(self): | ||
| if not (sys.platform.startswith('freebsd') or | ||
| sys.platform.startswith('linux')): | ||
| raise InstallError("libnl requires FreeBSD or Linux") |
Member
There was a problem hiding this comment.
Can we replace this whole thing with a conflicts statement? Something like:
conflicts('platform=darwin', msg='libnl requires FreeBSD or Linux')Unfortunately, Spack doesn't have a "not" in the spec syntax, so we would have to iterate through each platform (I don't even know what the full list is). But the benefit would be that Spack would crash during concretization instead of installation (before all of the dependencies are even installed).
Member
Author
There was a problem hiding this comment.
good suggestion - changed
adamjstewart
approved these changes
Apr 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New package, based on #6978 and #4168
The comments in #4168 addressed questions around which repo is canonical - seems there was consensus on using the thom311/libnl github repo.