r-htmltable: package update#7767
Conversation
| depends_on('r-magrittr', type=('build', 'run')) | ||
| depends_on('r-checkmate', type=('build', 'run')) | ||
| depends_on('r-htmlwidgets', type=('build', 'run')) | ||
| depends_on('r-rstudioapi', type=('build', 'run'), when="@1.11.2:") |
There was a problem hiding this comment.
Can you add the dependency version constraints? For example, [email protected]:
There was a problem hiding this comment.
done (as specified in htmlTable/DESCRIPTION source file).
| version('1.9', '08c62c19e1ffe570e7d8fa57db5094b9') | ||
|
|
||
| depends_on('r-stringr', type=('build', 'run')) | ||
| depends_on('r-knitr', type=('build', 'run')) |
There was a problem hiding this comment.
Can you specify the other dependency versions as well? See https://cran.r-project.org/web/packages/htmlTable/index.html
| depends_on('r-knitr', type=('build', 'run')) | ||
| depends_on('r-magrittr', type=('build', 'run')) | ||
| depends_on('r-knitr@1.6:', type=('build', 'run'), when="@1.11.2:") | ||
| depends_on('r-magrittr@1.5:', type=('build', 'run'), when="@1.11.2:") |
There was a problem hiding this comment.
These dependencies are the same for version 1.9 as well, no need to add the when here.
There was a problem hiding this comment.
Ok, 'whens' removed.
| depends_on('r-magrittr@1.5:', type=('build', 'run'), when="@1.11.2:") | ||
| depends_on('r-checkmate', type=('build', 'run')) | ||
| depends_on('r-htmlwidgets', type=('build', 'run')) | ||
| depends_on('[email protected]:', type=('build', 'run'), when="@1.11.2:") |
There was a problem hiding this comment.
This dependency was added in version 1.11.0, not 1.11.2.
There was a problem hiding this comment.
done.
will try to be more precise, this is my first set of packages for spack, I appreciate your guidelines.
4 participants
No description provided.