glib: updated package and fixed issues with dtrace#7493
glib: updated package and fixed issues with dtrace#7493alalazo merged 1 commit intospack:developfrom
Conversation
| # '/usr/bin/python' in the shebang. To work around that | ||
| # we copy the original script into a temporary folder, and | ||
| # change the shebang to '/usr/bin/env python' | ||
| dtrace = which('dtrace').path |
There was a problem hiding this comment.
I think the whole hack should be applied iff the dtrace command is found and it actually contains the hardcoded sbang but this could lead to a silently ignored tracing=dtrace variant. Does Spack have a policy for this kind of situations (e.g.: never ever ignore a variant, just let it fail)?
There was a problem hiding this comment.
Does Spack have a policy for this kind of situations (e.g.: never ever ignore a variant, just let it fail)?
Not really, at least as far as I know. @adamjstewart do you have an opinion on this one?
In any case, the should be applied if the command is found part is kind of already there - if dtrace is not found then which returns None and asking for .path will make it fail (not in a nice way and not with a nice message though).
|
Confirmed working on |
|
Is there some variant change that might bypass the glib build issue #7575 I reported this morning? |
4 participants
fixes #6965
closes #6968
@nazavode