Conversation
|
@adamjstewart: can you remove it? v3 is pretty much only for @jgalarowicz's |
|
Done. Keep in mind that we aren't even specifying the installation prefix though. |
| def common_config_args(self): | ||
| return [ | ||
| config_args = [ | ||
| '-prefix', self.prefix, |
There was a problem hiding this comment.
Yep, but version 3 isn't using common_config_args, so it isn't specifying the prefix. That's what I meant.
There was a problem hiding this comment.
@jgalarowicz: should your version 3 be using the common config args?
There was a problem hiding this comment.
I believe, when I tried to use the common_config_args there were configure options which qt3 didn't support and the configure failed. But that was a long time ago, so I'm not completely sure of my recollection. I can try again.
There was a problem hiding this comment.
If you can figure out which options aren't supported by qt3, we can move these out of the common_config_args and into qt4/5 specific ones.
There was a problem hiding this comment.
Ok. I'll give it another try and update this thread.
There was a problem hiding this comment.
Here is the first run output using:
@when('@3')
def configure(self):
configure('-fast',
'-thread',
*self.common_config_args)
PARTIAL OUPTUT:
See build log for details:
/tmp/jeg/spack-stage/spack-stage-9YDAba/qt-x11-free-3.3.8b/spack-build.out
/home/jeg/work_spack/spack/var/spack/repos/builtin/packages/qt/package.py:126, in configure:
122 @when('@3')
123 def configure(self):
124 configure('-fast',
125 '-thread',
126 self.common_config_args)
==> Error: Installation process had nonzero exit code.
[jeg@localhost packages]$ cat /tmp/jeg/spack-stage/spack-stage-9YDAba/qt-x11-free-3.3.8b/spack-build.out
==> ./configure -fast -thread -prefix /home/jeg/work_spack/spack/opt/spack/Linux-x86_64/gcc-4.8.3/qt-3.3.8b-alld534dmzulshzoqgzgrulpoy7ux7d2 -v -opensource -opengl -release -shared -confirm-license -openssl-linked -dbus-linked -optimized-qmake -no-openvg -no-pch -no-nis
-opensource: unknown argument
-opengl: unknown argument
-confirm-license: unknown argument
-openssl-linked: unknown argument
-dbus-linked: unknown argument
-optimized-qmake: unknown argument
-no-openvg: invalid command-line switch
IBASE auto-detection...
Could not find libgds. anywhere in /lib /usr/lib
IBASE disabled.
MySQL auto-detection...
Could not find libmysqlclient.* anywhere in /lib /usr/lib
MySQL disabled.
ODBC auto-detection...
Could not find libodbc.* anywhere in /lib /usr/lib
ODBC disabled.
PostgreSQL auto-detection...
Could not find libpq.* anywhere in /lib /usr/lib
PostgreSQL disabled.
CUPS auto-detection... ()
Found cups lib in /usr/lib
Found cups/cups.h in /usr/include
CUPS enabled.
OpenGL auto-detection... ()
Found GLU lib in /usr/lib
There was a problem hiding this comment.
Oh wow, so most of the common_config_args aren't compatible.
I don't know how I missed this, but it looks like qt3 does actually set the installation prefix already. In that case, this PR might be ready to go as is.
|
@tgamblin: I think we're good to go now. Someone should probably test this to make sure it's working, since I've never even installed Qt before. |
|
Ping. This is probably ready to merge. |
|
Needs a rebase. |
|
@tgamblin I finally figured out how to rebase without messing everything up! |
|
still says it's out of date... does it conflict w/something else? |
|
Let's try this again... |
|
apparently it was my new overly restrictive branch protections. I required things to be up to date before merging -- which is probably too strict. |
|
Yeah, I noticed that most of these didn't have any conflicts to resolve. That explains it. |
3 participants
As suggested in #704, this should hopefully prevent the use of a system GTK+ when
~gtkis chosen (the default). I haven't tested it myself, and I'm not familiar with qt, so someone else should test it.I assume the configure function for version 3 was missing
common_config_args? If not I can remove it.