Add url_for_version function and gtk variant#704
Conversation
|
|
||
| depends_on("glib") | ||
| depends_on("gtkplus") | ||
| depends_on("gtkplus", when='+gtk') |
There was a problem hiding this comment.
@mathstuf: @adamjstewart: @lee218llnl do you know of anything that relies on GTK support in Qt? This change makes gtk off by default, so other packages may need to ask specifically for it. Is it better to build Qt with gtk by default?
There was a problem hiding this comment.
This was done by request of #166. I'll let you guys decide whether it should default to True or False.
|
Asked @alfredo-gimenez. I do not believe he needs this for MemAxes. I think that is all. If there are packages that need Qt/GTK they will need to update their variants. Seems reasonable to have this off by default. |
|
@adamjstewart @alfredo-gimenez points out that when |
|
I'll add another PR to fix that. I don't think I can just push to the same branch, right? |
|
You can, but will need a new PR with a differently named branch or not. |
3 participants
I messed up #427 when trying to resolve conflicts, so here it is again.