Add CUDA and HOOMD-blue packages#702
Merged
tgamblin merged 3 commits intospack:developfrom Mar 31, 2016
Merged
Conversation
Member
|
@adamjstewart: awesome! Thanks for putting this together. I'd like to figure out and document some conventions for placing 3rd-party software where Spack can find it, maybe in a default mirror. Also the message should probably print out how to add an external CUDA installation to Spack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a package for CUDA. At first glance, the following packages can now be modified to add CUDA support:
I'm not familiar with most of these packages, so I'll let someone else add CUDA support to these after this gets merged.
Potential improvements that can be made:
Similar to #558, the runfile download must be done manually. What would be really cool would be to override whatever function attempts fetching and add a try/catch statement. If the package cannot be found (in this case meaning it is not in the current directory or in a mirror), then prompt the user letting them know that it needs to be manually downloaded.
This package does not handle driver installation. As far as I know, this needs to be done manually by disabling the Nouveau drivers and rebooting into text-mode (see CUDA Installation Guide). Perhaps I could add a
+drivervariant that handles the driver installation as long as the user is already in text-mode.CUDA also suffers from the same problem as #558, in which the filename depends not only on the version but also on the platform and architecture. We could require users to rename the file without those, but the checksum will still be different.