Change default build type to empty string#6970
Conversation
|
|
||
| try: | ||
| build_type = pkg.spec.variants['build_type'].value | ||
| build_type = pkg.spec.variants['build_type'].value or '' |
There was a problem hiding this comment.
I had no idea you could do this in Python!
There was a problem hiding this comment.
@scheibelp just showed it to me on a recent PR, it's great for keeping None checks clean!
|
Would it be worth adding a |
|
@scheibelp if we were to do that we would need to do it for all flag handlers, the bad behavior appears under all flag_handlers, it's about setting incompatible flags, in whatever way they are set. I don't think we would want to set that warning from the build environment, because then it would be written to the build log not the terminal. I'm not sure where before that we could set it though, without seeing it every time we concretize a spec, which I think would be overkill. I don't think it's a bad idea, but I'm not sure where we could reasonably set that message. |
|
Closing as stale (similarly to the recently closed #5265) |
For compatibility with compiler flags and similarity to CMake outside of Spack
Resolves #6961. For more detail, see the issue #6961.