Skip to content

+ libdrm depends_on libpciaccess. Use spack provided libpciaccess.#697

Merged
tgamblin merged 1 commit intospack:developfrom
KineticTheory:pkg-libdrm
Mar 31, 2016
Merged

+ libdrm depends_on libpciaccess. Use spack provided libpciaccess.#697
tgamblin merged 1 commit intospack:developfrom
KineticTheory:pkg-libdrm

Conversation

@KineticTheory
Copy link
Copy Markdown
Contributor

Running configure w/o optional arguments requires Intel atomics. If these are found, then pciaccess must also be found. Choose to use spack's version of libpciaccess.

@mathstuf
Copy link
Copy Markdown
Contributor

Maybe I'm not familiar enough with this part of the stack, but what does PCI access have to do with Intel atomic instructions?

@tgamblin tgamblin merged commit 2441068 into spack:develop Mar 31, 2016
@KineticTheory
Copy link
Copy Markdown
Contributor Author

@MathStuff It looks like I misread the configure.ac. Even so, the motivation for my change remains the same: The build fails for me if I don't depend on libpciaccess.

Reviewing configure.ac again this morning, it appears to set the default value of INTEL to 'auto'. It then runs a bunch of checks and leaves INTEL turned on if 'drm_cv_atomic_primitives = none'. Then it aborts on this check (unless libpciaccess is provided):

'
if test "x$INTEL" != "xno"; then
PKG_CHECK_MODULES(PCIACCESS, [pciaccess >= 0.10])
fi
'

If my change breaks the package for some folks, we turn the new dependency into variant.

@tgamblin
Copy link
Copy Markdown
Member

libdrm does depend on libpciaccess, so the change looks good to me.

@mathstuf
Copy link
Copy Markdown
Contributor

OK, that's all good. The commit message is just confusing :) .

@tgamblin
Copy link
Copy Markdown
Member

indeed 😄

@KineticTheory KineticTheory deleted the pkg-libdrm branch April 24, 2017 22:50
matz-e pushed a commit to matz-e/spack that referenced this pull request Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants