+ libdrm depends_on libpciaccess. Use spack provided libpciaccess.#697
+ libdrm depends_on libpciaccess. Use spack provided libpciaccess.#697tgamblin merged 1 commit intospack:developfrom
Conversation
|
Maybe I'm not familiar enough with this part of the stack, but what does PCI access have to do with Intel atomic instructions? |
|
@MathStuff It looks like I misread the configure.ac. Even so, the motivation for my change remains the same: The build fails for me if I don't depend on libpciaccess. Reviewing configure.ac again this morning, it appears to set the default value of INTEL to 'auto'. It then runs a bunch of checks and leaves INTEL turned on if 'drm_cv_atomic_primitives = none'. Then it aborts on this check (unless libpciaccess is provided): ' If my change breaks the package for some folks, we turn the new dependency into variant. |
|
|
|
OK, that's all good. The commit message is just confusing :) . |
|
indeed 😄 |
Running configure w/o optional arguments requires Intel atomics. If these are found, then pciaccess must also be found. Choose to use spack's version of libpciaccess.