WIP: Teach the metis recipe to respect spack's cflags#6840
Closed
KineticTheory wants to merge 2 commits intospack:developfrom
Closed
WIP: Teach the metis recipe to respect spack's cflags#6840KineticTheory wants to merge 2 commits intospack:developfrom
KineticTheory wants to merge 2 commits intospack:developfrom
Conversation
If the spack install command specifies cflags (either on the command line or in `compilers.yaml`), tell CMake to use only spack's cflags and none of its own default values. fixes spack#6839
Member
|
Contributor
Author
KineticTheory
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the spack install command specifies cflags (either on the command line or in
compilers.yaml), tell CMake to use only spack's cflags and none of its own default values.fixes #6839
The downside to this approach is that if cflags is set, then setting
build_type=<whatever>might not do what is expected because the cflags will trump cmake's build_type default compiler flags.