Skip to content

Suite sparse rename#598

Merged
tgamblin merged 3 commits intospack:developfrom
davydden:suite_sparse_rename
Mar 22, 2016
Merged

Suite sparse rename#598
tgamblin merged 3 commits intospack:developfrom
davydden:suite_sparse_rename

Conversation

@davydden
Copy link
Copy Markdown
Member

as nobody objected renaming suite sparse here #580, that's what this PR is about.

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Mar 22, 2016

I am not against this change, but please let's avoid an holy war on renaming...

@davydden
Copy link
Copy Markdown
Member Author

it's the only package which is named badly without a reason. Before we go ahead and use it in many other packages, i would suggest to fix the name.

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Mar 22, 2016

You know why I say that : it adds nothing and may leave bug behind. Try to install eigen+suitesparse now...

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Mar 22, 2016

Another thing is : it's not named badly without a reason. It was created following exactly what the documentation prescribes. If other software packagers decides to use CamelCase in a tar.gz the command spack create <url> won't produce a good name if we start to adopt this rule.

I find it more annoying that something prescribed in the docs doesn't work rather than a name in CamelCase. Of course this may be just my personal taste.

@davydden
Copy link
Copy Markdown
Member Author

i see you point. I grepped for SuiteSparse, so it should be good now with eigen and octave.

@davydden
Copy link
Copy Markdown
Member Author

as always, this is just a proposition. I ain't gonna be pissed of if the PR is not merged 😄

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Mar 22, 2016

Naturally, nothing personal intended, my comments were just to share my opinion on this. If I am minority and people want to merge I'll also get along with it 😄

@tgamblin
Copy link
Copy Markdown
Member

I'm leaving this up to @alalazo. I'm kind of agnostic and git blame shows he's the guy who added the package. I like lowercase + dashes and wouldn't be unhappy if spack create started naming things that way. I'm also not opposed to people renaming things away from what spack create picks if they think they've got a better name -- spack create is automatic and was intended mainly to get packagers up and running, not to create a precedent. You may be interested (or irritated?) to know that you can name packages starting with numbers... MacPorts had 3proxy (http://3proxy.ru) so I figured why not? Blame the Russians...

So up to you @alalazo.

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Mar 22, 2016

I am not against this change in particular, so it's fine with me to merge. My point more generally is that usually renaming spates bring more troubles than benefits : you know today it's suite sparse, tomorrow all the python modules... 😄

tgamblin added a commit that referenced this pull request Mar 22, 2016
@tgamblin tgamblin merged commit 1a3bdf0 into spack:develop Mar 22, 2016
@davydden davydden deleted the suite_sparse_rename branch May 28, 2017 20:58
matz-e pushed a commit to matz-e/spack that referenced this pull request Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants