Skip to content

Slightly better error matching when parsing spack logs#5236

Merged
tgamblin merged 1 commit intospack:developfrom
aprokop:error_match
Aug 30, 2017
Merged

Slightly better error matching when parsing spack logs#5236
tgamblin merged 1 commit intospack:developfrom
aprokop:error_match

Conversation

@aprokop
Copy link
Copy Markdown
Contributor

@aprokop aprokop commented Aug 29, 2017

When compiling llvm I got warnings that spack thought were errors. Things like this:

     11502 /home/xap/local/opt/spack/var/spack/stage/llvm-4.0.0-zy57t3src64pg4hijvf2hy2xzhwsbkab/llvm-4.0.0.src/lib/Support/YAMLParser.cpp:2119:5: note: here
  >> 11503 case Token::TK_Error:
     11504      ^~~~
     11505 /home/xap/local/opt/spack/var/spack/stage/llvm-4.0.0-zy57t3src64pg4hijvf2hy2xzhwsbkab/llvm-4.0.0.src/lib/Support/YAMLParser.cpp:2130:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
     11506        getNext();
     11507        ~~~~~~~^~

The problem is that matching "error:" should really check that it is a word.

I think adding \b should fix it, but have not tested it, and there may be a better way to do this.

@tgamblin
Copy link
Copy Markdown
Member

tgamblin commented Aug 29, 2017

The build didn't fail because of this, though, right?

@aprokop
Copy link
Copy Markdown
Contributor Author

aprokop commented Aug 29, 2017

@tgamblin No, a different reason.

@tgamblin tgamblin merged commit c830eda into spack:develop Aug 30, 2017
@tgamblin tgamblin mentioned this pull request Sep 17, 2017
Merged
1 task
@tgamblin tgamblin mentioned this pull request Oct 1, 2017
Merged
2 tasks
@aprokop aprokop deleted the error_match branch June 5, 2018 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgamblin tgamblin tgamblin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aprokop @tgamblin