Skip to content

config.yaml: default to new installer#52149

Merged
haampie merged 1 commit intodevelopfrom
hs/fix/installer-dispatch
Mar 26, 2026
Merged

config.yaml: default to new installer#52149
haampie merged 1 commit intodevelopfrom
hs/fix/installer-dispatch

Conversation

@haampie
Copy link
Copy Markdown
Member

@haampie haampie commented Mar 26, 2026

The new installer should be ready to be used by default on develop.

The new dispatch function takes unsupported features into account and falls
back to the old installer when needed.

Currently that's splicing and --until.

It's not enabled in all unit tests yet, because:

  • there are many tests that monkeypatch details from the old installer
  • there are many tests that expect it raises ChildError, which the new installer does not use
  • there are many tests that assert stdout details, which is different in the new installer

@github-actions github-actions bot added commands environments bootstrap Anything that has to do with Spack building its own dependencies. unit-tests config labels Mar 26, 2026
@haampie haampie force-pushed the hs/fix/installer-dispatch branch from a2fc579 to 4b482a5 Compare March 26, 2026 13:37
@haampie haampie force-pushed the hs/fix/installer-dispatch branch from 4b482a5 to 1f407dc Compare March 26, 2026 13:41
@alalazo alalazo self-assigned this Mar 26, 2026
@haampie haampie merged commit 0517e97 into develop Mar 26, 2026
31 of 32 checks passed
@haampie haampie deleted the hs/fix/installer-dispatch branch March 26, 2026 14:19
becker33 pushed a commit that referenced this pull request Mar 30, 2026
Use the new installer by default on Linux and Darwin.

Dispatch to old installer when using unsupported features (splicing, --until).

Signed-off-by: Harmen Stoppels <[email protected]>
Signed-off-by: Gregory Becker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bootstrap Anything that has to do with Spack building its own dependencies. commands config environments unit-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants