Removing unsupported variant from HDF5.#520
Merged
Conversation
- `unsupported` shouldn't be a variant.
Member
Author
|
@eschnett: I think I know your opinion. |
Member
Author
|
@alalazo ? |
Member
|
Cut'n paste from 70aa650: well I think my opinion is clear on that : if it was harmless the developer wouldn't have added that check. Anyhow, as you all agree, I guess I'll just have to remember to build |
Member
Author
|
Let's try merging. If this starts causing a lot of pain can you submit an issue? We can either put a warning in or work on better ways to specify policies per my comment on 70aa650. |
Member
|
@tgamblin ok |
tgamblin
added a commit
that referenced
this pull request
Mar 9, 2016
Removing `unsupported` variant from HDF5.
Merged
matz-e
pushed a commit
to matz-e/spack
that referenced
this pull request
Apr 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unsupportedshouldn't be a variant.@mathstuf: see #519 and #517. Does this make sense to you?