@eschnett @alalazo: ok I took out the HDF5 change. Now that I look at what unsupported does, why is it an option? Why don't we just remove the unsupported variant altogether, since it just allows us to use certain options together...

Good point. The option name sure is confusing.

@alalazo @citibeth I'll merge if this PR works for you. Not that it fixes some typos too.

I'd like to table this until we've merged support for build dependencies
into dev. The reason is that PETSc has a build dependency on Python 2.7,
but not a runtime dependency. To get it working (with my Python3-enabled
project), I'm having to temporarily comment out that dependency, since it
shows up to later packages as an actual dependency.

It would also be nice to figure out the Python2 vs Python3 issue, but I
don't think that's critical for PETSc.

On Wed, Mar 9, 2016 at 1:59 PM, Todd Gamblin [email protected]
wrote:

For review by @citibeth https://github.com/citibeth and @alalazo
https://github.com/alalazo. I have attempted to merge the concurrent

changes to petsc.

You can view, comment on, or merge this pull request online at:

#519
Commit Summary

• Merge @citibeth and @alalazo's petsc fixes from Fixed issues with hypre: #515 and Improved package : petsc #517

File Changes

• M var/spack/repos/builtin/packages/petsc/package.py (19)

Patch Links:

• https://github.com/LLNL/spack/pull/519.patch
• https://github.com/LLNL/spack/pull/519.diff

—
Reply to this email directly or view it on GitHub
#519.

@mathstuf should be done with build deps soon -- can we merge this and at least get the fixes in?

OK, the parts that I understand look good to me. (The stuff with hdf5 is going over my head right now, I'll defer to others).

My only suggestion would be to add a comment above the following code to explain in English what it does:

 +            errors = [error_message_fmt.format(library=x)
+                      for x in ('hdf5', 'hypre', 'parmetis')
+                      if ('+'+x) in self.spec]

Maybe:

# +hdf5, +hypre and +parmetis all require +mpi as well.

Ah, list comprehensions. I added some language to describe it. See what you think.