version_types.py: cache ClosedOpenRange __str__ and __hash__#51832
Merged
version_types.py: cache ClosedOpenRange __str__ and __hash__#51832
ClosedOpenRange __str__ and __hash__#51832Conversation
Since ClosedOpenRange is immutable we can cache its string representation and hash value. That saves the expensive `_prev_version` call. Signed-off-by: Harmen Stoppels <[email protected]>
haampie
force-pushed
the
hs/fix/closed-open-range-cache-str-hash
branch
from
68a8d23 to
ff6e898
Compare
Signed-off-by: Harmen Stoppels <[email protected]>
becker33
approved these changes
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
ClosedOpenRangeis immutable we can cache its stringand hash value in the named constructor, before the internal
representation of
hi = _next_version(hi)is computed.That saves the expensive, allocating
_prev_versioncall in__str__and reduces "setup time" by 7.4%.Should be the best of both worlds: the internal
_next_versionrepresentation allowed us to do non-allocating, fast range inclusion
checks as tuple comparsion, while this change ensures that
__str__doesn't have to compute the original
hifrom the input.