Merged
Conversation
fcf1edc to
fc344d4
Compare
Signed-off-by: Harmen Stoppels <[email protected]>
fc344d4 to
fc0f018
Compare
alalazo
approved these changes
Jan 9, 2026
becker33
pushed a commit
that referenced
this pull request
Jan 11, 2026
Logging in the new installer was modeled after the old installer, but it has proven to be problematic as it requires the stage dir to exist before a log file is created: 1. many things can go wrong before the stage dir is created 2. for build cache installs pkg.stage is obviously not used, but we do need a log file to troubleshoot failures. In the old installer this was no issue, because install from binary cache was done sequentially from the main process 3. there is output *before* creating the stage dir that needs to be silenced to not mess up the UI This commit generates a unique log file in the stage dir root, redirects output to that as early as possible, and then ultimately symlinks the log file in the package stage dir in the usual location during source builds. Signed-off-by: Harmen Stoppels <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 11, 2026
Logging in the new installer was modeled after the old installer, but it has proven to be problematic as it requires the stage dir to exist before a log file is created: 1. many things can go wrong before the stage dir is created 2. for build cache installs pkg.stage is obviously not used, but we do need a log file to troubleshoot failures. In the old installer this was no issue, because install from binary cache was done sequentially from the main process 3. there is output *before* creating the stage dir that needs to be silenced to not mess up the UI This commit generates a unique log file in the stage dir root, redirects output to that as early as possible, and then ultimately symlinks the log file in the package stage dir in the usual location during source builds. Signed-off-by: Harmen Stoppels <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 12, 2026
Logging in the new installer was modeled after the old installer, but it has proven to be problematic as it requires the stage dir to exist before a log file is created: 1. many things can go wrong before the stage dir is created 2. for build cache installs pkg.stage is obviously not used, but we do need a log file to troubleshoot failures. In the old installer this was no issue, because install from binary cache was done sequentially from the main process 3. there is output *before* creating the stage dir that needs to be silenced to not mess up the UI This commit generates a unique log file in the stage dir root, redirects output to that as early as possible, and then ultimately symlinks the log file in the package stage dir in the usual location during source builds. Signed-off-by: Harmen Stoppels <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 15, 2026
Logging in the new installer was modeled after the old installer, but it has proven to be problematic as it requires the stage dir to exist before a log file is created: 1. many things can go wrong before the stage dir is created 2. for build cache installs pkg.stage is obviously not used, but we do need a log file to troubleshoot failures. In the old installer this was no issue, because install from binary cache was done sequentially from the main process 3. there is output *before* creating the stage dir that needs to be silenced to not mess up the UI This commit generates a unique log file in the stage dir root, redirects output to that as early as possible, and then ultimately symlinks the log file in the package stage dir in the usual location during source builds. Signed-off-by: Harmen Stoppels <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
vjranagit
pushed a commit
to vjranagit/spack
that referenced
this pull request
Jan 18, 2026
Logging in the new installer was modeled after the old installer, but it has proven to be problematic as it requires the stage dir to exist before a log file is created: 1. many things can go wrong before the stage dir is created 2. for build cache installs pkg.stage is obviously not used, but we do need a log file to troubleshoot failures. In the old installer this was no issue, because install from binary cache was done sequentially from the main process 3. there is output *before* creating the stage dir that needs to be silenced to not mess up the UI This commit generates a unique log file in the stage dir root, redirects output to that as early as possible, and then ultimately symlinks the log file in the package stage dir in the usual location during source builds. Signed-off-by: Harmen Stoppels <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 22, 2026
Logging in the new installer was modeled after the old installer, but it has proven to be problematic as it requires the stage dir to exist before a log file is created: 1. many things can go wrong before the stage dir is created 2. for build cache installs pkg.stage is obviously not used, but we do need a log file to troubleshoot failures. In the old installer this was no issue, because install from binary cache was done sequentially from the main process 3. there is output *before* creating the stage dir that needs to be silenced to not mess up the UI This commit generates a unique log file in the stage dir root, redirects output to that as early as possible, and then ultimately symlinks the log file in the package stage dir in the usual location during source builds. Signed-off-by: Harmen Stoppels <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 26, 2026
Logging in the new installer was modeled after the old installer, but it has proven to be problematic as it requires the stage dir to exist before a log file is created: 1. many things can go wrong before the stage dir is created 2. for build cache installs pkg.stage is obviously not used, but we do need a log file to troubleshoot failures. In the old installer this was no issue, because install from binary cache was done sequentially from the main process 3. there is output *before* creating the stage dir that needs to be silenced to not mess up the UI This commit generates a unique log file in the stage dir root, redirects output to that as early as possible, and then ultimately symlinks the log file in the package stage dir in the usual location during source builds. Signed-off-by: Harmen Stoppels <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging in the new installer was modeled after the old installer, but it has
proven to be problematic as it requires the stage dir to exist before a log
file is created:
need a log file to troubleshoot failures. In the old installer this was
no issue, because install from binary cache was done sequentially
from the main process
not mess up the UI
This commit generates a unique log file in the stage dir root, redirects output
to that as early as possible, and then ultimately symlinks the log file
in the package stage dir in the usual location during source builds.
Also, fixes two other issues:
the install prefix. Otherwise it's not complete, or worse, it may not even
exist on the filesystem and cause a build failure.