solver: exclude externals from deprecation penalties#51764
Merged
haampie merged 6 commits intospack:developfrom Dec 16, 2025
Merged
solver: exclude externals from deprecation penalties#51764haampie merged 6 commits intospack:developfrom
haampie merged 6 commits intospack:developfrom
Conversation
Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
…ilt spec Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
haampie
reviewed
Dec 16, 2025
Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
haampie
approved these changes
Dec 16, 2025
becker33
pushed a commit
that referenced
this pull request
Jan 16, 2026
#51591 started applying deprecation penalties also to external specs. Here we restore the previous semantics and exclude externals from taking a deprecation penalty. This is done applying a separate: ```prolog deprecation_penalty(PackageNode, Penalty). ``` in the ASP problem, according to certain rules. This makes it easier to debug whether a penalty for deprecation was taken, and to add or modify behavior around deprecation in following PRs. Signed-off-by: Massimiliano Culpo <[email protected]>
vjranagit
pushed a commit
to vjranagit/spack
that referenced
this pull request
Jan 18, 2026
spack#51591 started applying deprecation penalties also to external specs. Here we restore the previous semantics and exclude externals from taking a deprecation penalty. This is done applying a separate: ```prolog deprecation_penalty(PackageNode, Penalty). ``` in the ASP problem, according to certain rules. This makes it easier to debug whether a penalty for deprecation was taken, and to add or modify behavior around deprecation in following PRs. Signed-off-by: Massimiliano Culpo <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 22, 2026
#51591 started applying deprecation penalties also to external specs. Here we restore the previous semantics and exclude externals from taking a deprecation penalty. This is done applying a separate: ```prolog deprecation_penalty(PackageNode, Penalty). ``` in the ASP problem, according to certain rules. This makes it easier to debug whether a penalty for deprecation was taken, and to add or modify behavior around deprecation in following PRs. Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 26, 2026
#51591 started applying deprecation penalties also to external specs. Here we restore the previous semantics and exclude externals from taking a deprecation penalty. This is done applying a separate: ```prolog deprecation_penalty(PackageNode, Penalty). ``` in the ASP problem, according to certain rules. This makes it easier to debug whether a penalty for deprecation was taken, and to add or modify behavior around deprecation in following PRs. Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#51591 started applying deprecation penalties also to external specs. Here we restore the previous semantics and exclude externals from taking a deprecation penalty.
This is done applying a separate:
in the ASP problem, according to certain rules. This makes it easier to debug whether a penalty for deprecation was taken, and to add or modify behavior around deprecation in following PRs.
Benchmarks
radiuss.develop.csv
radiuss.pr.csv