spec parser: ensure toolchains are expanded to different objects#51731
Merged
becker33 merged 1 commit intospack:developfrom Dec 12, 2025
Merged
spec parser: ensure toolchains are expanded to different objects#51731becker33 merged 1 commit intospack:developfrom
becker33 merged 1 commit intospack:developfrom
Conversation
fixes spack#51606 If "foo %gnu ^bar %gnu" has %gnu expanding to the same object in memory, it may happen that some facts for the literal spec are not emitted correctly. Signed-off-by: Massimiliano Culpo <[email protected]>
alalazo
added
bugfix
3 tasks
becker33
approved these changes
Dec 12, 2025
Member
|
Actually, quick question -- wouldn't it be more robust to fix this by changing the |
Member
Author
Hmm, not really. We use that branch to descend into sub-graphs which is a per node decision. Probably the most robust solution is to fix the TODO in #51727 but that is much bigger than this PR. |
Member
|
I'm not convinced "every node is a separate object" is a good assumption in abstract specs, even without this bug. But that can be a separate conversation. |
becker33
pushed a commit
that referenced
this pull request
Jan 10, 2026
) fixes #51606 If "foo %gnu ^bar %gnu" has %gnu expanding to the same object in memory, it may happen that some facts for the literal spec are not emitted correctly. Signed-off-by: Massimiliano Culpo <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 11, 2026
) fixes #51606 If "foo %gnu ^bar %gnu" has %gnu expanding to the same object in memory, it may happen that some facts for the literal spec are not emitted correctly. Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 15, 2026
) fixes #51606 If "foo %gnu ^bar %gnu" has %gnu expanding to the same object in memory, it may happen that some facts for the literal spec are not emitted correctly. Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
vjranagit
pushed a commit
to vjranagit/spack
that referenced
this pull request
Jan 18, 2026
…ck#51731) fixes spack#51606 If "foo %gnu ^bar %gnu" has %gnu expanding to the same object in memory, it may happen that some facts for the literal spec are not emitted correctly. Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 22, 2026
) fixes #51606 If "foo %gnu ^bar %gnu" has %gnu expanding to the same object in memory, it may happen that some facts for the literal spec are not emitted correctly. Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 26, 2026
) fixes #51606 If "foo %gnu ^bar %gnu" has %gnu expanding to the same object in memory, it may happen that some facts for the literal spec are not emitted correctly. Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
Member
|
This PR does not apply cleanly to releases/v1.0 and will be dropped from v1.0.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #51606
If:
has
%gnuexpanding to the same objects in memory, it may happen that some facts for the literal spec are not emitted correctly.