python 3.14: handle stdout/stderr redirection with forkerserver in tests#51663
Merged
python 3.14: handle stdout/stderr redirection with forkerserver in tests#51663
Conversation
63d848b to
3d9059a
Compare
bf98839 to
4ea2d60
Compare
alalazo
previously approved these changes
Dec 2, 2025
4ea2d60 to
6608f6b
Compare
Member
Author
6608f6b to
c01b02b
Compare
alalazo
previously approved these changes
Dec 3, 2025
c01b02b to
307ba77
Compare
Signed-off-by: Harmen Stoppels <[email protected]>
307ba77 to
c613fd9
Compare
alalazo
approved these changes
Dec 9, 2025
becker33
pushed a commit
that referenced
this pull request
Jan 10, 2026
When using forkserver, there is no guarantee that stdout/stderr in the subprocess spawned by multiprocessing corresponds to the same file as the one in the parent process, as we're forking a different Python process. This is particularly the case when Spack is running under pytest, which redirects stdout/stderr to a temporary file for each test. So, pass stdout/stderr from the parent process to the child if forkserver is the start method. Signed-off-by: Harmen Stoppels <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 11, 2026
When using forkserver, there is no guarantee that stdout/stderr in the subprocess spawned by multiprocessing corresponds to the same file as the one in the parent process, as we're forking a different Python process. This is particularly the case when Spack is running under pytest, which redirects stdout/stderr to a temporary file for each test. So, pass stdout/stderr from the parent process to the child if forkserver is the start method. Signed-off-by: Harmen Stoppels <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 15, 2026
When using forkserver, there is no guarantee that stdout/stderr in the subprocess spawned by multiprocessing corresponds to the same file as the one in the parent process, as we're forking a different Python process. This is particularly the case when Spack is running under pytest, which redirects stdout/stderr to a temporary file for each test. So, pass stdout/stderr from the parent process to the child if forkserver is the start method. Signed-off-by: Harmen Stoppels <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
vjranagit
pushed a commit
to vjranagit/spack
that referenced
this pull request
Jan 18, 2026
When using forkserver, there is no guarantee that stdout/stderr in the subprocess spawned by multiprocessing corresponds to the same file as the one in the parent process, as we're forking a different Python process. This is particularly the case when Spack is running under pytest, which redirects stdout/stderr to a temporary file for each test. So, pass stdout/stderr from the parent process to the child if forkserver is the start method. Signed-off-by: Harmen Stoppels <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 22, 2026
When using forkserver, there is no guarantee that stdout/stderr in the subprocess spawned by multiprocessing corresponds to the same file as the one in the parent process, as we're forking a different Python process. This is particularly the case when Spack is running under pytest, which redirects stdout/stderr to a temporary file for each test. So, pass stdout/stderr from the parent process to the child if forkserver is the start method. Signed-off-by: Harmen Stoppels <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 26, 2026
When using forkserver, there is no guarantee that stdout/stderr in the subprocess spawned by multiprocessing corresponds to the same file as the one in the parent process, as we're forking a different Python process. This is particularly the case when Spack is running under pytest, which redirects stdout/stderr to a temporary file for each test. So, pass stdout/stderr from the parent process to the child if forkserver is the start method. Signed-off-by: Harmen Stoppels <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
Merged
becker33
pushed a commit
that referenced
this pull request
Feb 2, 2026
When using forkserver, there is no guarantee that stdout/stderr in the subprocess spawned by multiprocessing corresponds to the same file as the one in the parent process, as we're forking a different Python process. This is particularly the case when Spack is running under pytest, which redirects stdout/stderr to a temporary file for each test. So, pass stdout/stderr from the parent process to the child if forkserver is the start method. Signed-off-by: Harmen Stoppels <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Feb 2, 2026
When using forkserver, there is no guarantee that stdout/stderr in the subprocess spawned by multiprocessing corresponds to the same file as the one in the parent process, as we're forking a different Python process. This is particularly the case when Spack is running under pytest, which redirects stdout/stderr to a temporary file for each test. So, pass stdout/stderr from the parent process to the child if forkserver is the start method. Signed-off-by: Harmen Stoppels <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Feb 19, 2026
When using forkserver, there is no guarantee that stdout/stderr in the subprocess spawned by multiprocessing corresponds to the same file as the one in the parent process, as we're forking a different Python process. This is particularly the case when Spack is running under pytest, which redirects stdout/stderr to a temporary file for each test. So, pass stdout/stderr from the parent process to the child if forkserver is the start method. Signed-off-by: Harmen Stoppels <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using forkserver, there is no guarantee that stdout/stderr in the subprocess spawned by multiprocessing corresponds to the same file as the one in the parent process, as we're forking a different Python process.
This is particularly the case when Spack is running under pytest, which redirects stdout/stderr to a temporary file for each test.
So, pass stdout/stderr from the parent process to the child if forkserver is the start method.