Bugfix: List the component prefix not the root#51635
Merged
becker33 merged 1 commit intospack:developfrom Nov 26, 2025
Merged
Conversation
Member
|
Maybe add a test? |
becker33
reviewed
Nov 25, 2025
Member
becker33
left a comment
becker33
left a comment
There was a problem hiding this comment.
Looks great, agree with Harmen it would be nice to have a test.
I think the easiest way to test would probably be to create a directory that shouldn't be read and put a file in it with no read permissions -- then we can look for that error in the output
Contributor
Author
|
Yeah it needs a test, I just pushed this quickly so the people experiencing the bug could use it right away. I should have a block of time later today to finish this up. |
kwryankrattiger
force-pushed
the
bc_list_component_prefix
branch
from
0922a73 to
4060262
Compare
kwryankrattiger
force-pushed
the
bc_list_component_prefix
branch
from
4060262 to
02ae1e3
Compare
Recursively listing a buildcache from the root will result in finding components in other buildcaches that may also exist under that same root. This can lead to degraded performance and errors for many build cache operations. Signed-off-by: Ryan Krattiger <[email protected]>
kwryankrattiger
force-pushed
the
bc_list_component_prefix
branch
from
02ae1e3 to
4adb178
Compare
becker33
approved these changes
Nov 26, 2025
Member
|
@kwryankrattiger the |
Contributor
Author
I had asked @becker33 what we were using, thanks for the clarification |
psakievich
pushed a commit
to psakievich/spack
that referenced
this pull request
Dec 1, 2025
Recursively listing a buildcache from the root will result in finding components in other buildcaches that may also exist under that same root. This can lead to degraded performance and errors for many build cache operations. Signed-off-by: Ryan Krattiger <[email protected]>
hippo91
pushed a commit
to hippo91/spack
that referenced
this pull request
Dec 1, 2025
Recursively listing a buildcache from the root will result in finding components in other buildcaches that may also exist under that same root. This can lead to degraded performance and errors for many build cache operations. Signed-off-by: Ryan Krattiger <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 10, 2026
Recursively listing a buildcache from the root will result in finding components in other buildcaches that may also exist under that same root. This can lead to degraded performance and errors for many build cache operations. Signed-off-by: Ryan Krattiger <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 11, 2026
Recursively listing a buildcache from the root will result in finding components in other buildcaches that may also exist under that same root. This can lead to degraded performance and errors for many build cache operations. Signed-off-by: Ryan Krattiger <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 15, 2026
Recursively listing a buildcache from the root will result in finding components in other buildcaches that may also exist under that same root. This can lead to degraded performance and errors for many build cache operations. Signed-off-by: Ryan Krattiger <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
vjranagit
pushed a commit
to vjranagit/spack
that referenced
this pull request
Jan 18, 2026
Recursively listing a buildcache from the root will result in finding components in other buildcaches that may also exist under that same root. This can lead to degraded performance and errors for many build cache operations. Signed-off-by: Ryan Krattiger <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 22, 2026
Recursively listing a buildcache from the root will result in finding components in other buildcaches that may also exist under that same root. This can lead to degraded performance and errors for many build cache operations. Signed-off-by: Ryan Krattiger <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 26, 2026
Recursively listing a buildcache from the root will result in finding components in other buildcaches that may also exist under that same root. This can lead to degraded performance and errors for many build cache operations. Signed-off-by: Ryan Krattiger <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recursively listing a buildcache from the root will result in finding components in other buildcaches that may also exist under that same root. This can lead to degraded performance and errors for many build cache operations.