solver: manually optimize trigger_node projections#51605
Merged
alalazo merged 1 commit intospack:developfrom Nov 19, 2025
Merged
solver: manually optimize trigger_node projections#51605alalazo merged 1 commit intospack:developfrom
alalazo merged 1 commit intospack:developfrom
Conversation
Project out trigger node in its own rule, instead of using anonymous variables. This should help the grounder avoiding cartesian products that lead to the same head. Signed-off-by: Massimiliano Culpo <[email protected]>
psakievich
pushed a commit
to psakievich/spack
that referenced
this pull request
Dec 1, 2025
Project out trigger node in its own rule, instead of using anonymous variables. This should help the grounder avoiding cartesian products that lead to the same head. Signed-off-by: Massimiliano Culpo <[email protected]>
harshula
pushed a commit
to ACCESS-NRI/spack
that referenced
this pull request
Dec 9, 2025
* Cherry-picked upstream commit b76b43c Project out trigger node in its own rule, instead of using anonymous variables. This should help the grounder avoiding cartesian products that lead to the same head. Signed-off-by: Massimiliano Culpo <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 11, 2026
Project out trigger node in its own rule, instead of using anonymous variables. This should help the grounder avoiding cartesian products that lead to the same head. Signed-off-by: Massimiliano Culpo <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 11, 2026
Project out trigger node in its own rule, instead of using anonymous variables. This should help the grounder avoiding cartesian products that lead to the same head. Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 12, 2026
Project out trigger node in its own rule, instead of using anonymous variables. This should help the grounder avoiding cartesian products that lead to the same head. Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 15, 2026
Project out trigger node in its own rule, instead of using anonymous variables. This should help the grounder avoiding cartesian products that lead to the same head. Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
vjranagit
pushed a commit
to vjranagit/spack
that referenced
this pull request
Jan 18, 2026
Project out trigger node in its own rule, instead of using anonymous variables. This should help the grounder avoiding cartesian products that lead to the same head. Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 22, 2026
Project out trigger node in its own rule, instead of using anonymous variables. This should help the grounder avoiding cartesian products that lead to the same head. Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Jan 26, 2026
Project out trigger node in its own rule, instead of using anonymous variables. This should help the grounder avoiding cartesian products that lead to the same head. Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Gregory Becker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project out
trigger_nodein its own rule, instead of using anonymous variables. This should help the grounder avoiding Cartesian products that lead to the same head in rules with a larger domain, and does not rely on optimizations that may or may not be done.Overall, the encoding seems to have a very small, but positive effect on concretization:
radiuss.develop.csv
radiuss.pr.csv