[WIP] error messages: add control statements only when errors are generated#51576
Closed
scheibelp wants to merge 1 commit intospack:developfrom
Closed
[WIP] error messages: add control statements only when errors are generated#51576scheibelp wants to merge 1 commit intospack:developfrom
scheibelp wants to merge 1 commit intospack:developfrom
Conversation
1 task
Member
Author
|
On further consideration, I think I cannot change anything about the original failed solve, only potentially derive more facts from what was already there, so I think this (or anything like it) would not work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an (incomplete) attempt at handling the performance regression in #45800
The statements that cause the performance regression are only required for error messages (see: #45800 (comment)), so I wanted to try moving them out of the base program. It does not appear to work - at least the way I tried it.