spack repo remove: allow removing from unspecified scope#51563
Merged
spack repo remove: allow removing from unspecified scope#51563
Conversation
Signed-off-by: Gregory Becker <[email protected]>
Signed-off-by: Gregory Becker <[email protected]>
Signed-off-by: Gregory Becker <[email protected]>
Member
|
We might want to warn users if the same repo exists from multiple config scopes. The current functionality wipes out the corresponding repository name from all scopes without any confirmation. |
Signed-off-by: Gregory Becker <[email protected]>
Signed-off-by: Gregory Becker <[email protected]>
Member
Author
|
Summarizing conversation that we had offline: The behavior that @alecbcs noticed was intentional. This was designed to work on repos that have e.g. their This seems like non-ideal behvior as well. We are going to take this offline and try to have a conversatoin with more devs and figure out what is the least confusing way to handle this. We briefly considered |
Signed-off-by: Gregory Becker <[email protected]>
Signed-off-by: Gregory Becker <[email protected]>
alecbcs
reviewed
Nov 24, 2025
alecbcs
previously approved these changes
Nov 24, 2025
Member
alecbcs
left a comment
alecbcs
left a comment
There was a problem hiding this comment.
One nitpick, otherwise looks good to me.
Signed-off-by: Gregory Becker <[email protected]>
alecbcs
approved these changes
Nov 24, 2025
psakievich
pushed a commit
to psakievich/spack
that referenced
this pull request
Dec 1, 2025
* spack repo rm: remove from all scopes when none provided Signed-off-by: Gregory Becker <[email protected]> * unit test for repo removal from unspecified scope Signed-off-by: Gregory Becker <[email protected]> * cleanup unit test Signed-off-by: Gregory Becker <[email protected]> * apply same fix to mirrors Signed-off-by: Gregory Becker <[email protected]> * style Signed-off-by: Gregory Becker <[email protected]> * remove from top scope with option for all scopes Signed-off-by: Gregory Becker <[email protected]> * update_completions Signed-off-by: Gregory Becker <[email protected]> * move tty usage to cmd Signed-off-by: Gregory Becker <[email protected]> --------- Signed-off-by: Gregory Becker <[email protected]>
hippo91
pushed a commit
to hippo91/spack
that referenced
this pull request
Dec 1, 2025
* spack repo rm: remove from all scopes when none provided Signed-off-by: Gregory Becker <[email protected]> * unit test for repo removal from unspecified scope Signed-off-by: Gregory Becker <[email protected]> * cleanup unit test Signed-off-by: Gregory Becker <[email protected]> * apply same fix to mirrors Signed-off-by: Gregory Becker <[email protected]> * style Signed-off-by: Gregory Becker <[email protected]> * remove from top scope with option for all scopes Signed-off-by: Gregory Becker <[email protected]> * update_completions Signed-off-by: Gregory Becker <[email protected]> * move tty usage to cmd Signed-off-by: Gregory Becker <[email protected]> --------- Signed-off-by: Gregory Becker <[email protected]>
becker33
added a commit
that referenced
this pull request
Jan 10, 2026
* spack repo rm: remove from all scopes when none provided Signed-off-by: Gregory Becker <[email protected]> * unit test for repo removal from unspecified scope Signed-off-by: Gregory Becker <[email protected]> * cleanup unit test Signed-off-by: Gregory Becker <[email protected]> * apply same fix to mirrors Signed-off-by: Gregory Becker <[email protected]> * style Signed-off-by: Gregory Becker <[email protected]> * remove from top scope with option for all scopes Signed-off-by: Gregory Becker <[email protected]> * update_completions Signed-off-by: Gregory Becker <[email protected]> * move tty usage to cmd Signed-off-by: Gregory Becker <[email protected]> --------- Signed-off-by: Gregory Becker <[email protected]>
becker33
added a commit
that referenced
this pull request
Jan 11, 2026
* spack repo rm: remove from all scopes when none provided Signed-off-by: Gregory Becker <[email protected]> * unit test for repo removal from unspecified scope Signed-off-by: Gregory Becker <[email protected]> * cleanup unit test Signed-off-by: Gregory Becker <[email protected]> * apply same fix to mirrors Signed-off-by: Gregory Becker <[email protected]> * style Signed-off-by: Gregory Becker <[email protected]> * remove from top scope with option for all scopes Signed-off-by: Gregory Becker <[email protected]> * update_completions Signed-off-by: Gregory Becker <[email protected]> * move tty usage to cmd Signed-off-by: Gregory Becker <[email protected]> --------- Signed-off-by: Gregory Becker <[email protected]>
becker33
added a commit
that referenced
this pull request
Jan 15, 2026
* spack repo rm: remove from all scopes when none provided Signed-off-by: Gregory Becker <[email protected]> * unit test for repo removal from unspecified scope Signed-off-by: Gregory Becker <[email protected]> * cleanup unit test Signed-off-by: Gregory Becker <[email protected]> * apply same fix to mirrors Signed-off-by: Gregory Becker <[email protected]> * style Signed-off-by: Gregory Becker <[email protected]> * remove from top scope with option for all scopes Signed-off-by: Gregory Becker <[email protected]> * update_completions Signed-off-by: Gregory Becker <[email protected]> * move tty usage to cmd Signed-off-by: Gregory Becker <[email protected]> --------- Signed-off-by: Gregory Becker <[email protected]>
vjranagit
pushed a commit
to vjranagit/spack
that referenced
this pull request
Jan 18, 2026
* spack repo rm: remove from all scopes when none provided Signed-off-by: Gregory Becker <[email protected]> * unit test for repo removal from unspecified scope Signed-off-by: Gregory Becker <[email protected]> * cleanup unit test Signed-off-by: Gregory Becker <[email protected]> * apply same fix to mirrors Signed-off-by: Gregory Becker <[email protected]> * style Signed-off-by: Gregory Becker <[email protected]> * remove from top scope with option for all scopes Signed-off-by: Gregory Becker <[email protected]> * update_completions Signed-off-by: Gregory Becker <[email protected]> * move tty usage to cmd Signed-off-by: Gregory Becker <[email protected]> --------- Signed-off-by: Gregory Becker <[email protected]>
becker33
added a commit
that referenced
this pull request
Jan 22, 2026
* spack repo rm: remove from all scopes when none provided Signed-off-by: Gregory Becker <[email protected]> * unit test for repo removal from unspecified scope Signed-off-by: Gregory Becker <[email protected]> * cleanup unit test Signed-off-by: Gregory Becker <[email protected]> * apply same fix to mirrors Signed-off-by: Gregory Becker <[email protected]> * style Signed-off-by: Gregory Becker <[email protected]> * remove from top scope with option for all scopes Signed-off-by: Gregory Becker <[email protected]> * update_completions Signed-off-by: Gregory Becker <[email protected]> * move tty usage to cmd Signed-off-by: Gregory Becker <[email protected]> --------- Signed-off-by: Gregory Becker <[email protected]>
becker33
added a commit
that referenced
this pull request
Jan 26, 2026
* spack repo rm: remove from all scopes when none provided Signed-off-by: Gregory Becker <[email protected]> * unit test for repo removal from unspecified scope Signed-off-by: Gregory Becker <[email protected]> * cleanup unit test Signed-off-by: Gregory Becker <[email protected]> * apply same fix to mirrors Signed-off-by: Gregory Becker <[email protected]> * style Signed-off-by: Gregory Becker <[email protected]> * remove from top scope with option for all scopes Signed-off-by: Gregory Becker <[email protected]> * update_completions Signed-off-by: Gregory Becker <[email protected]> * move tty usage to cmd Signed-off-by: Gregory Becker <[email protected]> --------- Signed-off-by: Gregory Becker <[email protected]>
Merged
becker33
added a commit
that referenced
this pull request
Feb 2, 2026
* spack repo rm: remove from all scopes when none provided Signed-off-by: Gregory Becker <[email protected]> * unit test for repo removal from unspecified scope Signed-off-by: Gregory Becker <[email protected]> * cleanup unit test Signed-off-by: Gregory Becker <[email protected]> * apply same fix to mirrors Signed-off-by: Gregory Becker <[email protected]> * style Signed-off-by: Gregory Becker <[email protected]> * remove from top scope with option for all scopes Signed-off-by: Gregory Becker <[email protected]> * update_completions Signed-off-by: Gregory Becker <[email protected]> * move tty usage to cmd Signed-off-by: Gregory Becker <[email protected]> --------- Signed-off-by: Gregory Becker <[email protected]>
becker33
added a commit
that referenced
this pull request
Feb 2, 2026
* spack repo rm: remove from all scopes when none provided Signed-off-by: Gregory Becker <[email protected]> * unit test for repo removal from unspecified scope Signed-off-by: Gregory Becker <[email protected]> * cleanup unit test Signed-off-by: Gregory Becker <[email protected]> * apply same fix to mirrors Signed-off-by: Gregory Becker <[email protected]> * style Signed-off-by: Gregory Becker <[email protected]> * remove from top scope with option for all scopes Signed-off-by: Gregory Becker <[email protected]> * update_completions Signed-off-by: Gregory Becker <[email protected]> * move tty usage to cmd Signed-off-by: Gregory Becker <[email protected]> --------- Signed-off-by: Gregory Becker <[email protected]>
becker33
added a commit
that referenced
this pull request
Feb 19, 2026
* spack repo rm: remove from all scopes when none provided Signed-off-by: Gregory Becker <[email protected]> * unit test for repo removal from unspecified scope Signed-off-by: Gregory Becker <[email protected]> * cleanup unit test Signed-off-by: Gregory Becker <[email protected]> * apply same fix to mirrors Signed-off-by: Gregory Becker <[email protected]> * style Signed-off-by: Gregory Becker <[email protected]> * remove from top scope with option for all scopes Signed-off-by: Gregory Becker <[email protected]> * update_completions Signed-off-by: Gregory Becker <[email protected]> * move tty usage to cmd Signed-off-by: Gregory Becker <[email protected]> --------- Signed-off-by: Gregory Becker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the following fails:
It fails because the
spack repo removecommand requires a scope to remove from, and assumes--scope userif unspecified.This PR changes this to remove the matching repo from any scope if the scope is unspecified. Because portions of the repo could be defined at different config levels, it removes the specified repo from every scope. Removing from a specific scope is still supported, using the
--scopeargument.The analogous bug exists and is fixed in the analogous manner for
spack mirror removein this PR as well.Includes tests.