bugfix: don't stop early when other spacks are installing#51539
Merged
bugfix: don't stop early when other spacks are installing#51539
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Fixes #50933. The installer in #47590 missed a loop condition and wasn't properly waiting on tasks requeued as `BuildStatus.INSTALLING`. This means another Spack is working on that task, and we should wait and not bail early. There is also a condition in the installer where we disocver for the first time that a package is installed in cleanup. We need to update the installed dependencies lists of dependents when that happens. Signed-off-by: Todd Gamblin <[email protected]>
tgamblin
force-pushed
the
bugfix-early-stop-on-multi-node-install
branch
from
61a768e to
8aa813a
Compare
rbberger
approved these changes
Nov 9, 2025
Member
rbberger
left a comment
rbberger
left a comment
There was a problem hiding this comment.
Had issues making the current Spack develop fail with my reproducer. However, cherry-picking this commit onto an older commit eaf413e, which still consistently was failing with the reproducer made the failures go away. So, LGTM.
|
Can confirm that this PR resolves concurrent runs of |
Member
|
We probably want this bugfix in v1.1.0 |
alalazo
pushed a commit
that referenced
this pull request
Nov 13, 2025
The installer in #47590 missed a loop condition and wasn't properly waiting on tasks requeued as `BuildStatus.INSTALLING`. This means another Spack process is working on that task, and we should wait and not bail early. There is also a condition in the installer where we discover for the first time that a package is installed in cleanup. We need to update the installed dependencies lists of dependents when that happens. Signed-off-by: Todd Gamblin <[email protected]>
alalazo
pushed a commit
that referenced
this pull request
Nov 13, 2025
The installer in #47590 missed a loop condition and wasn't properly waiting on tasks requeued as `BuildStatus.INSTALLING`. This means another Spack process is working on that task, and we should wait and not bail early. There is also a condition in the installer where we discover for the first time that a package is installed in cleanup. We need to update the installed dependencies lists of dependents when that happens. Signed-off-by: Todd Gamblin <[email protected]> Signed-off-by: Massimiliano Culpo <[email protected]>
alalazo
pushed a commit
that referenced
this pull request
Nov 13, 2025
The installer in #47590 missed a loop condition and wasn't properly waiting on tasks requeued as `BuildStatus.INSTALLING`. This means another Spack process is working on that task, and we should wait and not bail early. There is also a condition in the installer where we discover for the first time that a package is installed in cleanup. We need to update the installed dependencies lists of dependents when that happens. Signed-off-by: Todd Gamblin <[email protected]> Signed-off-by: Massimiliano Culpo <[email protected]>
haampie
pushed a commit
that referenced
this pull request
Nov 14, 2025
The installer in #47590 missed a loop condition and wasn't properly waiting on tasks requeued as `BuildStatus.INSTALLING`. This means another Spack process is working on that task, and we should wait and not bail early. There is also a condition in the installer where we discover for the first time that a package is installed in cleanup. We need to update the installed dependencies lists of dependents when that happens. Signed-off-by: Todd Gamblin <[email protected]> Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]>
becker33
pushed a commit
that referenced
this pull request
Nov 14, 2025
The installer in #47590 missed a loop condition and wasn't properly waiting on tasks requeued as `BuildStatus.INSTALLING`. This means another Spack process is working on that task, and we should wait and not bail early. There is also a condition in the installer where we discover for the first time that a package is installed in cleanup. We need to update the installed dependencies lists of dependents when that happens. Signed-off-by: Todd Gamblin <[email protected]> Signed-off-by: Massimiliano Culpo <[email protected]> Signed-off-by: Harmen Stoppels <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50933.
The installer in #47590 missed a loop condition and wasn't properly waiting on tasks requeued as
BuildStatus.INSTALLING. This means another Spack is working on that task, and we should wait and not bail early.There is also a condition in the installer where we disocver for the first time that a package is installed in cleanup. We need to update the installed dependencies lists of dependents when that happens.