install: Avoid env.write_transacation when concretize is a no-op.#51535
Open
vbrunini wants to merge 2 commits intospack:developfrom
Open
install: Avoid env.write_transacation when concretize is a no-op.#51535vbrunini wants to merge 2 commits intospack:developfrom
vbrunini wants to merge 2 commits intospack:developfrom
Conversation
Signed-off-by: Victor Brunini <[email protected]>
vbrunini
added a commit
to vbrunini/spack
that referenced
this pull request
Nov 8, 2025
Combined with spack#51535, spack#51536, spack#51367 and the reduced install task sleep time from spack#51491 this reduces the time for a no-op install of a development environment with 94 packages (including dependencies) from 8s to 2.8s for me. It also provides a similar reduction in time for `spack build-env --dump env.txt mypkg` which we frequently use to start a shell with the build environment. Signed-off-by: Victor Brunini <[email protected]>
This was referenced Nov 8, 2025
Signed-off-by: Victor Brunini <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #51518 based on review comments. @haampie