Don't spawn a process for --fake installs#51491
Merged
tgamblin merged 3 commits intospack:developfrom Oct 31, 2025
Merged
Conversation
FakeBuildTask doesn't spawn Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
alalazo
commented
Oct 31, 2025
becker33
previously approved these changes
Oct 31, 2025
Signed-off-by: Massimiliano Culpo <[email protected]>
becker33
approved these changes
Oct 31, 2025
tgamblin
approved these changes
Oct 31, 2025
hippo91
pushed a commit
to hippo91/spack
that referenced
this pull request
Nov 4, 2025
Modifications: - [x] Don't spawn a process for `--fake` installs - [x] `sleep` for 10ms instead of 100ms in the installer This has been shown to speed up tests (18s vs. 12s) on an Intel Mac laptop. `0.1` seems to be too much sleep time. --------- Signed-off-by: Massimiliano Culpo <[email protected]>
kshea21
pushed a commit
to kshea21/spack
that referenced
this pull request
Nov 4, 2025
Modifications: - [x] Don't spawn a process for `--fake` installs - [x] `sleep` for 10ms instead of 100ms in the installer This has been shown to speed up tests (18s vs. 12s) on an Intel Mac laptop. `0.1` seems to be too much sleep time. --------- Signed-off-by: Massimiliano Culpo <[email protected]>
vbrunini
added a commit
to vbrunini/spack
that referenced
this pull request
Nov 6, 2025
By using a cache for Spec objects and reducing the number of copies of Spec objects being done. Combined with spack#51367 and the reduced install task sleep time from spack#51491 this reduces the time for a no-op install of a development environment with 94 packages (including dependencies) from 8s to 2.8s for me. It also provides a similar reduction in time for `spack build-env --dump env.txt mypkg` which we frequently use to start a shell with the build environment. Signed-off-by: Victor Brunini <[email protected]>
vbrunini
added a commit
to vbrunini/spack
that referenced
this pull request
Nov 8, 2025
Combined with spack#51535, spack#51536, spack#51367 and the reduced install task sleep time from spack#51491 this reduces the time for a no-op install of a development environment with 94 packages (including dependencies) from 8s to 2.8s for me. It also provides a similar reduction in time for `spack build-env --dump env.txt mypkg` which we frequently use to start a shell with the build environment. Signed-off-by: Victor Brunini <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications:
--fakeinstallssleepfor 10ms instead of 100ms in the installerOn an Intel-based macOS laptop:
