Use gethostname instead of getfqdn to speed-up macOS unit tests in CI#51481
Merged
tgamblin merged 1 commit intospack:developfrom Oct 30, 2025
Merged
Conversation
Signed-off-by: Massimiliano Culpo <[email protected]>
Member
Author
|
I wonder if we can use Since we are near to a release, I opted for this minimal change, but if the approach seems good enough we can submit a following PR. |
Member
Author
|
|
johnwparent
approved these changes
Oct 29, 2025
tgamblin
approved these changes
Oct 30, 2025
kshea21
pushed a commit
to kshea21/spack
that referenced
this pull request
Nov 4, 2025
`getfqdn` can be extremely slow in CI. Use `gethostname()` instead. --- Signed-off-by: Massimiliano Culpo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #51469
For reference, removing
socket.getfqdnimproved the unit tests time on macOS:It's another instance of #46554 that got in through the
sbanghook in #47590. Since hooks are run on the child and on macOS the sub-processes are "spawned" (not "forked"), memoization doesn't help.