macos unit tests: reduce parallelism, use Python 3.13#51469
Closed
alalazo wants to merge 8 commits intospack:developfrom
Closed
macos unit tests: reduce parallelism, use Python 3.13#51469alalazo wants to merge 8 commits intospack:developfrom
alalazo wants to merge 8 commits intospack:developfrom
Conversation
alalazo
force-pushed
the
qa/tweak-macos-config
branch
from
bb5b1ba to
b792af6
Compare
Member
Author
|
Something about the slow macOS tests in CI: We lose 35 sec. on one call to the built-in method |
alalazo
force-pushed
the
qa/tweak-macos-config
branch
from
fb0b1c2 to
e54601c
Compare
Member
Author
|
For reference, removing
It's another instance of #46554 that got in through the |
alalazo
force-pushed
the
qa/tweak-macos-config
branch
from
cae2ab0 to
498538f
Compare
alalazo
force-pushed
the
qa/tweak-macos-config
branch
from
724a132 to
9f8452c
Compare
Member
Author
|
Another thing that is making our unit tests on macOS go extremely slow is spawning subprocesses for unit tests: We should avoid subprocesses in general in unit tests. I'll experiment with creating a |
Currently, we are oversubscribing macos-latest runners by 1 cpu, and we are using all macos-15-intel CPUs. This commit wants to check if, using less parallelism, we could get faster unit tests in CI. Also, bump Python from 3.11 to 3.13 Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
FakeBuildTask doesn't spawn Signed-off-by: Massimiliano Culpo <[email protected]>
alalazo
force-pushed
the
qa/tweak-macos-config
branch
from
9f8452c to
ff43d4e
Compare
Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
Signed-off-by: Massimiliano Culpo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we are oversubscribing macos-latest runners by 1 cpu, and we are using all macos-15-intel CPUs. This commit wants to check if, using less parallelism, we could get faster unit tests in CI.
Also, bump Python from 3.11 to 3.13